Project

Profile

Help

Issue #6077

closed

A wrong logical operator used in the method for validation of a signing script

Added by lmjachky almost 3 years ago. Updated almost 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix
Sprint:
Sprint 66
Quarter:

Description

In the commit https://github.com/pulp/pulpcore/commit/b7829ee71113f7cd9d24866fc91bca7d1b590848, there was introduced an interface for a signing service.

When an administrator is trying to save a signing script to the database, Pulp performs additional checks whether the signing script is valid or not. On the line https://github.com/pulp/pulpcore/commit/b7829ee71113f7cd9d24866fc91bca7d1b590848#diff-5308662d441ee7c5774295277cba139cR433, however, there is an invalid logical operator used for validating a trust level. Instead of the 'and' operator, there should be used 'or'.

Actions #1

Updated by bmbouter almost 3 years ago

  • Sprint set to Sprint 65

Adding to sprint since it's fixing a feature we just released.

Added by Lubos Mjachky almost 3 years ago

Revision fcdfa8d1

Fix an invalid logical operator

closes #6077 https://pulp.plan.io/issues/6077

Actions #2

Updated by lmjachky almost 3 years ago

  • Status changed from ASSIGNED to POST
Actions #3

Updated by fao89 almost 3 years ago

  • Triaged changed from No to Yes
Actions #4

Updated by rchan almost 3 years ago

  • Sprint changed from Sprint 65 to Sprint 66
Actions #5

Updated by Anonymous almost 3 years ago

  • Status changed from POST to MODIFIED

Added by Lubos Mjachky almost 3 years ago

Revision 42a42e6b

Fix an invalid logical operator

closes #6077 https://pulp.plan.io/issues/6077

(cherry picked from commit fcdfa8d1673818f7d81aedefbe11617739bca78d)

Actions #6

Updated by Anonymous almost 3 years ago

Actions #7

Updated by bmbouter almost 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions #8

Updated by bmbouter almost 3 years ago

  • Sprint/Milestone set to 3.1.1

Also available in: Atom PDF