Project

Profile

Help

Issue #6077

A wrong logical operator used in the method for validation of a signing script

Added by lmjachky 10 months ago. Updated 9 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix
Sprint:
Sprint 66
Quarter:

Description

In the commit https://github.com/pulp/pulpcore/commit/b7829ee71113f7cd9d24866fc91bca7d1b590848, there was introduced an interface for a signing service.

When an administrator is trying to save a signing script to the database, Pulp performs additional checks whether the signing script is valid or not. On the line https://github.com/pulp/pulpcore/commit/b7829ee71113f7cd9d24866fc91bca7d1b590848#diff-5308662d441ee7c5774295277cba139cR433, however, there is an invalid logical operator used for validating a trust level. Instead of the 'and' operator, there should be used 'or'.

Associated revisions

Revision fcdfa8d1 View on GitHub
Added by Lubos Mjachky 10 months ago

Fix an invalid logical operator

closes #6077 https://pulp.plan.io/issues/6077

Revision 42a42e6b View on GitHub
Added by Lubos Mjachky 9 months ago

Fix an invalid logical operator

closes #6077 https://pulp.plan.io/issues/6077

(cherry picked from commit fcdfa8d1673818f7d81aedefbe11617739bca78d)

History

#1 Updated by bmbouter 10 months ago

  • Sprint set to Sprint 65

Adding to sprint since it's fixing a feature we just released.

#2 Updated by lmjachky 10 months ago

  • Status changed from ASSIGNED to POST

#3 Updated by fao89 10 months ago

  • Triaged changed from No to Yes

#4 Updated by rchan 10 months ago

  • Sprint changed from Sprint 65 to Sprint 66

#5 Updated by Anonymous 10 months ago

  • Status changed from POST to MODIFIED

#6 Updated by Anonymous 9 months ago

#7 Updated by bmbouter 9 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

#8 Updated by bmbouter 9 months ago

  • Sprint/Milestone set to 3.1.1

Please register to edit this issue

Also available in: Atom PDF