Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #5826

closed

bindings ruby and python libraries are missing license or declare (somewhat) incorrect one

Added by jsherril@redhat.com about 4 years ago. Updated over 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
fao89
Category:
-
Sprint/Milestone:
3.3.0
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Documentation
Sprint:
Sprint 68
Quarter:

Description

The python bindings do not seem to provide any sort of license: https://pypi.org/project/pulp-ansible-client/#description

and the ruby bindings suggest it is using GPLv2, but in reality its more accurately GPLv2+ https://rubygems.org/gems/pulp_file_client

Actions
Copy link
 #1

Updated by fao89 about 4 years ago

  • Sprint/Milestone set to 3.0.0
  • Triaged changed from No to Yes
  • Sprint set to Sprint 62
Actions
Copy link
 #2

Updated by bmbouter about 4 years ago

  • Tags Documentation added
Actions
Copy link
 #3

Updated by daviddavis almost 4 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to daviddavis
Actions
Copy link
 #4

Updated by daviddavis almost 4 years ago

I can fix the ruby gem license easily as it just requires modifying this line:

https://github.com/pulp/pulp-openapi-generator/blob/9ad63e8cd90bf995b7e11c9da0315483b778f490/generate.sh#L35

The python bindings license is trickier as there currently is no option for the python generator:

https://openapi-generator.tech/docs/generators/python

Actions
Copy link
 #5

Updated by rchan almost 4 years ago

  • Sprint changed from Sprint 62 to Sprint 63

Added by daviddavis almost 4 years ago

Revision e0c4f4bb | View on GitHub

Fixing the ruby bindings license

ref #5826

Actions
Copy link
 #6

Updated by daviddavis almost 4 years ago

Opened a PR to fix the ruby bindings gem license: https://github.com/pulp/pulp-openapi-generator/pull/23

The python bindings will require a PR to openapi-generator which I am working on.

Actions
Copy link
 #7

Updated by daviddavis almost 4 years ago

  • Sprint/Milestone deleted (3.0.0)

Per discussion with bmbouter, removing this as a 3.0 blocker since it's a separate deliverable.

Actions
Copy link
 #8

Updated by rchan almost 4 years ago

  • Sprint changed from Sprint 63 to Sprint 64
Actions
Copy link
 #9

Updated by rchan almost 4 years ago

  • Sprint changed from Sprint 64 to Sprint 65
Actions
Copy link
 #10

Updated by rchan almost 4 years ago

  • Sprint changed from Sprint 65 to Sprint 66
Actions
Copy link
 #11

Updated by rchan almost 4 years ago

  • Sprint changed from Sprint 66 to Sprint 67
Actions
Copy link
 #12

Updated by rchan almost 4 years ago

  • Sprint changed from Sprint 67 to Sprint 68
Actions
Copy link
 #13

Updated by fao89 over 3 years ago

not sure if it would work due indentation https://github.com/pulp/plugin_template/pull/195/files

Added by Fabricio Aguiar over 3 years ago

Revision c4dfda02 | View on GitHub

Including license on python bindings client

https://pulp.plan.io/issues/5826 closes #5826

Actions
Copy link
 #14

Updated by daviddavis over 3 years ago

  • Status changed from ASSIGNED to POST
  • Assignee changed from daviddavis to fao89
Actions
Copy link
 #15

Updated by Anonymous over 3 years ago

  • Status changed from POST to MODIFIED
Actions
Copy link
 #16

Updated by ttereshc over 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
  • Sprint/Milestone set to 3.3.0
Actions
Send by e-mail Copy link

Also available in: Atom PDF