Actions
Task #5810
closed
plugin-template and pulpcore should use additional_plugins var to specify the pulp_file branch
Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:
100%
Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
CI/CD, Plugin Template
Sprint:
Quarter:
Description
When https://pulp.plan.io/issues/5782 was merged to fix CI quickly for non-master branches, we made an expedient design decision:
pulpcore (which has lots of special logic in plugin-template) used "pulpcore_branch" to specify the branch of pulp_file it wants.
We should use the new additional_plugins variable instead for the branch of pulp_file.
Related issues
Actions
.
Problem: plugin-template & pulpcore should use additional_plugins
to specify pulp_file's branch instead of pulpcore_branch.
Solution: Have pulpcore use additional_plugins for pulp_file, (except where hardcoding pulp_file leads to much simpler code) and do corresponding code cleanup and refactoring so that pulp_file does not get installed twice.
Also did some whitespace cleanup.
re: https://github.com/pulp/pulpcore/pull/409
Fixes: #5810 plugin-template and pulpcore should use additional_plugins var to specify the pulp_file branch https://pulp.plan.io/issues/5810