Project

Profile

Help

Task #5810

plugin-template and pulpcore should use additional_plugins var to specify the pulp_file branch

Added by mdepaulo@redhat.com about 1 year ago. Updated about 1 year ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
CI/CD, Plugin Template
Sprint:
Quarter:

Description

When https://pulp.plan.io/issues/5782 was merged to fix CI quickly for non-master branches, we made an expedient design decision:

pulpcore (which has lots of special logic in plugin-template) used "pulpcore_branch" to specify the branch of pulp_file it wants.

We should use the new additional_plugins variable instead for the branch of pulp_file.


Related issues

Follows Pulp - Issue #5782: plugin-template needs to support both the pulpcore 3.0 and master branch for pluginsCLOSED - CURRENTRELEASE<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

Associated revisions

Revision d9406951 View on GitHub
Added by Mike DePaulo about 1 year ago

Problem: plugin-template & pulpcore should use additional_plugins

to specify pulp_file's branch instead of pulpcore_branch.

Solution: Have pulpcore use additional_plugins for pulp_file, (except where hardcoding pulp_file leads to much simpler code) and do corresponding code cleanup and refactoring so that pulp_file does not get installed twice.

Also did some whitespace cleanup.

re: https://github.com/pulp/pulpcore/pull/409

Fixes: #5810 plugin-template and pulpcore should use additional_plugins var to specify the pulp_file branch https://pulp.plan.io/issues/5810

Revision f4b76f24 View on GitHub
Added by Mike DePaulo about 1 year ago

Problem: Travis config is out of date

And I need a plugin to test the latest changes in it for regressions.

Solution: re-generate with latest plugin-template.

re: #5810 plugin-template and pulpcore should use additional_plugins var to specify the pulp_file branch https://pulp.plan.io/issues/5810 [noissue]

Revision f4b76f24 View on GitHub
Added by Mike DePaulo about 1 year ago

Problem: Travis config is out of date

And I need a plugin to test the latest changes in it for regressions.

Solution: re-generate with latest plugin-template.

re: #5810 plugin-template and pulpcore should use additional_plugins var to specify the pulp_file branch https://pulp.plan.io/issues/5810 [noissue]

Revision 2a5fb16f View on GitHub
Added by Mike DePaulo about 1 year ago

Problem: plugin-template & pulpcore should use additional_plugins

to specify pulp_file's branch instead of pulpcore_branch.

Solution: re-generate with latest template, and update pre_before_install.sh to read additional_plugins.

re: https://github.com/pulp/pulpcore/pull/409

re: #5810 plugin-template and pulpcore should use additional_plugins var to specify the pulp_file branch https://pulp.plan.io/issues/5810

[noissue]

Revision f0a8f884 View on GitHub
Added by Mike DePaulo about 1 year ago

Problem: plugin-template & pulpcore should use additional_plugins

to specify pulp_file's branch instead of pulpcore_branch.

Solution: re-generate with latest template, and update pre_before_install.sh to read additional_plugins.

re: https://github.com/pulp/pulpcore/pull/409

re: #5810 plugin-template and pulpcore should use additional_plugins var to specify the pulp_file branch https://pulp.plan.io/issues/5810

[noissue]

Revision a023f4fe View on GitHub
Added by Mike DePaulo about 1 year ago

Problem: Travis config is out of date

And I need a plugin to test the latest changes in it for regressions.

Solution: re-generate with latest plugin-template.

re: #5810 plugin-template and pulpcore should use additional_plugins var to specify the pulp_file branch https://pulp.plan.io/issues/5810 [noissue]

(cherry picked from commit f4b76f2405f4b89b59ee4a35a318c0e295dd1c52)

Revision a023f4fe View on GitHub
Added by Mike DePaulo about 1 year ago

Problem: Travis config is out of date

And I need a plugin to test the latest changes in it for regressions.

Solution: re-generate with latest plugin-template.

re: #5810 plugin-template and pulpcore should use additional_plugins var to specify the pulp_file branch https://pulp.plan.io/issues/5810 [noissue]

(cherry picked from commit f4b76f2405f4b89b59ee4a35a318c0e295dd1c52)

History

#1 Updated by mdepaulo@redhat.com about 1 year ago

  • Follows Issue #5782: plugin-template needs to support both the pulpcore 3.0 and master branch for plugins added

#2 Updated by fao89 about 1 year ago

  • Tracker changed from Issue to Task
  • % Done set to 0

#3 Updated by Anonymous about 1 year ago

  • Status changed from NEW to MODIFIED
  • % Done changed from 0 to 100

#4 Updated by fao89 about 1 year ago

  • Tags CI/CD added

#5 Updated by bmbouter about 1 year ago

  • Sprint/Milestone set to 3.0.0

#6 Updated by bmbouter about 1 year ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF