Task #5810
closed
plugin-template and pulpcore should use additional_plugins var to specify the pulp_file branch
100%
Description
When https://pulp.plan.io/issues/5782 was merged to fix CI quickly for non-master branches, we made an expedient design decision:
pulpcore (which has lots of special logic in plugin-template) used "pulpcore_branch" to specify the branch of pulp_file it wants.
We should use the new additional_plugins variable instead for the branch of pulp_file.
Related issues
Updated by mdepaulo@redhat.com about 5 years ago
- Follows Issue #5782: plugin-template needs to support both the pulpcore 3.0 and master branch for plugins added
Added by Mike DePaulo about 5 years ago
Added by Mike DePaulo about 5 years ago
Revision f4b76f24 | View on GitHub
Problem: Travis config is out of date
And I need a plugin to test the latest changes in it for regressions.
Solution: re-generate with latest plugin-template.
re: #5810 plugin-template and pulpcore should use additional_plugins var to specify the pulp_file branch https://pulp.plan.io/issues/5810 [noissue]
Added by Mike DePaulo about 5 years ago
Revision f4b76f24 | View on GitHub
Problem: Travis config is out of date
And I need a plugin to test the latest changes in it for regressions.
Solution: re-generate with latest plugin-template.
re: #5810 plugin-template and pulpcore should use additional_plugins var to specify the pulp_file branch https://pulp.plan.io/issues/5810 [noissue]
Updated by fao89 about 5 years ago
- Tracker changed from Issue to Task
- % Done set to 0
Updated by Anonymous about 5 years ago
- Status changed from NEW to MODIFIED
- % Done changed from 0 to 100
Applied in changeset plugin_template|d940695143ecf8bebc3d6ca2bf56d34b07ffd7b9.
Added by Mike DePaulo about 5 years ago
Revision 2a5fb16f | View on GitHub
Problem: plugin-template & pulpcore should use additional_plugins
to specify pulp_file's branch instead of pulpcore_branch.
Solution: re-generate with latest template, and update pre_before_install.sh to read additional_plugins.
re: https://github.com/pulp/pulpcore/pull/409
re: #5810 plugin-template and pulpcore should use additional_plugins var to specify the pulp_file branch https://pulp.plan.io/issues/5810
[noissue]
Added by Mike DePaulo about 5 years ago
Revision f0a8f884 | View on GitHub
Problem: plugin-template & pulpcore should use additional_plugins
to specify pulp_file's branch instead of pulpcore_branch.
Solution: re-generate with latest template, and update pre_before_install.sh to read additional_plugins.
re: https://github.com/pulp/pulpcore/pull/409
re: #5810 plugin-template and pulpcore should use additional_plugins var to specify the pulp_file branch https://pulp.plan.io/issues/5810
[noissue]
Added by Mike DePaulo about 5 years ago
Revision a023f4fe | View on GitHub
Problem: Travis config is out of date
And I need a plugin to test the latest changes in it for regressions.
Solution: re-generate with latest plugin-template.
re: #5810 plugin-template and pulpcore should use additional_plugins var to specify the pulp_file branch https://pulp.plan.io/issues/5810 [noissue]
(cherry picked from commit f4b76f2405f4b89b59ee4a35a318c0e295dd1c52)
Added by Mike DePaulo about 5 years ago
Revision a023f4fe | View on GitHub
Problem: Travis config is out of date
And I need a plugin to test the latest changes in it for regressions.
Solution: re-generate with latest plugin-template.
re: #5810 plugin-template and pulpcore should use additional_plugins var to specify the pulp_file branch https://pulp.plan.io/issues/5810 [noissue]
(cherry picked from commit f4b76f2405f4b89b59ee4a35a318c0e295dd1c52)
Updated by bmbouter about 5 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
.
Problem: plugin-template & pulpcore should use additional_plugins
to specify pulp_file's branch instead of pulpcore_branch.
Solution: Have pulpcore use additional_plugins for pulp_file, (except where hardcoding pulp_file leads to much simpler code) and do corresponding code cleanup and refactoring so that pulp_file does not get installed twice.
Also did some whitespace cleanup.
re: https://github.com/pulp/pulpcore/pull/409
Fixes: #5810 plugin-template and pulpcore should use additional_plugins var to specify the pulp_file branch https://pulp.plan.io/issues/5810