Issue #5782
closed
plugin-template needs to support both the pulpcore 3.0 and master branch for plugins
Description
Right now plugin-template by default installs pulpcore from the master branch. Only "Required PR" causes it to be overriden, or setup.py (for the latest 3.0 release on PyPI.)
But sometimes plugins need newer features on the 3.0 branch than PyPI has.
plugin-template should have a variable for which branch to use for pulpcore. The variable's value should differ per plugin's branch.
Related issues
Updated by mdepaulo@redhat.com about 5 years ago
- Assignee set to mdepaulo@redhat.com
Updated by mdepaulo@redhat.com about 5 years ago
- Tracker changed from Issue to Task
- % Done set to 0
Added by Mike DePaulo about 5 years ago
Updated by mdepaulo@redhat.com about 5 years ago
- Tracker changed from Task to Issue
- Severity set to 2. Medium
- Triaged set to No
Added by Mike DePaulo about 5 years ago
Revision c5bf890e | View on GitHub
Problem: CI is failing for pulp-container's 1.0 branch
due to it needing pulp 3.0, but master is getting installed.
Solution: regenerate from plugin-template, and set pulpcore_branch: master/master & 1.0/3.0
[noissue]
re: #5782 plugin-template needs to support both the pulpcore 3.0 and master branch for plugins https://pulp.plan.io/issues/5782
Added by Mike DePaulo about 5 years ago
Revision c5bf890e | View on GitHub
Problem: CI is failing for pulp-container's 1.0 branch
due to it needing pulp 3.0, but master is getting installed.
Solution: regenerate from plugin-template, and set pulpcore_branch: master/master & 1.0/3.0
[noissue]
re: #5782 plugin-template needs to support both the pulpcore 3.0 and master branch for plugins https://pulp.plan.io/issues/5782
Added by Mike DePaulo about 5 years ago
Revision 2ac51031 | View on GitHub
Problem: CI is failing for pulp-container's 1.0 branch
due to it needing pulp 3.0, but master is getting installed.
Solution: regenerate from plugin-template, and set pulpcore_branch: master/master & 1.0/3.0
[noissue]
re: #5782 plugin-template needs to support both the pulpcore 3.0 and master branch for plugins https://pulp.plan.io/issues/5782
Added by Mike DePaulo about 5 years ago
Revision 2ac51031 | View on GitHub
Problem: CI is failing for pulp-container's 1.0 branch
due to it needing pulp 3.0, but master is getting installed.
Solution: regenerate from plugin-template, and set pulpcore_branch: master/master & 1.0/3.0
[noissue]
re: #5782 plugin-template needs to support both the pulpcore 3.0 and master branch for plugins https://pulp.plan.io/issues/5782
Added by Mike DePaulo about 5 years ago
Revision e12a3a53 | View on GitHub
Problem: Travis will eventually check out the wrong plugin branches for pulpcore 3.0.
Solution:
- Regenerate with latest plugin-template,
- "repurpose" its var pulpcore_branch as the branch for pulp_file: master/master & 3.0/0.1
- Specify the current only branch for pulp-certguard: master
- Add plugin-template's standard bash settings for robustness and verbosity to pre_before_install.sh
Also cleanup the effectively empty .travis/post_script.sh
[noissue]
re: #5782 plugin-template needs to support both the pulpcore 3.0 and master branch for plugins https://pulp.plan.io/issues/5782
Updated by Anonymous about 5 years ago
- Status changed from NEW to MODIFIED
Applied in changeset plugin_template|cc0d93cc8e0416333034798b0a570f8529ef904f.
Updated by mdepaulo@redhat.com about 5 years ago
- Precedes Task #5810: plugin-template and pulpcore should use additional_plugins var to specify the pulp_file branch added
Updated by mdepaulo@redhat.com about 5 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
.
Problem: plugin-template needs to support both the pulpcore 3.0 and master branch for plugins
Solution: specify it in the template_config variable pulpcore_branch Also reworks additional_plugins into both names and branches The few plugins currently using additional_plugins must update that variable in plugin_template.yml
Fixes: #5782 plugin-template needs to support both the pulpcore 3.0 and master branch for plugins https://pulp.plan.io/issues/5782