Pulp

Here is a commit that demonstrates the solution: https://github.com/pulp/pulp_file/pull/302/commits/bdf00a085f22450cc008406d6f9084fdec777eec

I am wondering whether we could make use of environment markers [0].

[0] https://www.python.org/dev/peps/pep-0508/#environment-markers

I don't think we can make good use of environment markers because there a limited number of them. We would want to use markers that we create. I don't think that is possible.

what about using the following names for files?

test_requirements.txt - contains requirements for functional tests
unittest_requirements.txt - contains requirements for unit tests
style_requirements.txt - requirements for the static analysis or style and such

What about moving style requirements into dev_requirements.txt and having a test_requirements.txt and func_test_requirements.txt?

i like that @daviddavis

daviddavis wrote:

What about moving style requirements into dev_requirements.txt and having a test_requirements.txt and func_test_requirements.txt?

+1

daviddavis wrote:

What about moving style requirements into dev_requirements.txt and having a test_requirements.txt and func_test_requirements.txt?

I like that and I have one suggestion: It is possible to include requirement files in other requirement files.

We could have unittest_requirements.txt and functest_requirements.txt to make the CI happy. The usual test_requirements.txt would just include both files.

This is a very good idea IMHO. We want to install as little software as possible in the containers to minimize the risk of invalidating the containers for testing. Missing (optional) deps are often the source of bugs (as a former sysadmin, I can tell you this.)

I do think that "test_requirements.txt" should be called something like "functest_requirements.txt" (like gmbnomis said.) Otherwise, unittest_requirements.txt might be assumed to be a subset of it.

Requirement files cannot include other requirement files. So we should go with:

dev_requirements.txt
unittest_requirements.txt
functest_requirements.txt

I would like to move forward with making this change.

It was pointed out to me that you can indeed reference requirement files in a requirements file. So that means we will have:

dev_requirements.txt
unittest_requirements.txt
functest_requirements.txt
test_requirements.txt (which will simply reference the previous 2)