Task #5629
closed
Introduce CONTENT_ORIGIN as a required setting
100%
Description
As discussed on the mailing list we need a new required setting because:
1. plugins like pulp_docker require this CONTENT_HOST to be set, but others may not, so this setting could become a dividing line for plugins that want it set versus those that don't.
2. Clients are semantically unsure how to handle responses for one Pulp server versus another. This setting changes the client's responsibilities (relative vs absolute URL handling).
3. Relative urls are not as usable as absolute urls.
Solution¶
Add a setting named CONTENT_ORIGIN that is required.
Updated by daviddavis over 4 years ago
- Sprint set to Sprint 61
This is a 3.0 GA blocker. Adding to sprint.
Updated by bmbouter over 4 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to bmbouter
Updated by fao89 over 4 years ago
- Tracker changed from Issue to Task
- % Done set to 0
Updated by bmbouter over 4 years ago
- Subject changed from Rename CONTENT_HOST to CONTENT_ORIGIN to Introduce CONTENT_ORIGIN as a required setting
- Description updated (diff)
Updated by bmbouter over 4 years ago
- Status changed from ASSIGNED to NEW
- Assignee deleted (
bmbouter)
Updated by bmbouter over 4 years ago
- Subject changed from Introduce CONTENT_ORIGIN as a required setting to [Epic] Introduce CONTENT_ORIGIN as a required setting
Added by bmbouter over 4 years ago
Added by Mike DePaulo over 4 years ago
Revision c7ee477c | View on GitHub
Set content_origin to the 1st node's 1st address.
If not set by the user.
Limited scope (single-node clusters), but sufficient for minikube/k3s/our Travis CI. fixes: #5138 In pulp-operator, the content_origin should be set to the actual accessible service URL https://pulp.plan.io/issues/5138
re: #5629 [Epic] Introduce CONTENT_ORIGIN as a required setting https://pulp.plan.io/issues/5629
Updated by bmbouter over 4 years ago
- Subject changed from [Epic] Introduce CONTENT_ORIGIN as a required setting to Introduce CONTENT_ORIGIN as a required setting
Updated by daviddavis over 4 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to daviddavis
Added by bmbouter over 4 years ago
Revision e027cd3f | View on GitHub
Introduce CONTENT_ORIGIN setting
This also adds a check that the user specified CONTENT_ORIGIN at startup. Pulp refuses to start if it is not set with an error message for the user.
Required PR: https://github.com/PulpQE/pulp-smash/pull/1227 Required PR: https://github.com/pulp/ansible-pulp/pull/185 Required PR: https://github.com/pulp/pulp_file/pull/303
Added by bmbouter over 4 years ago
Revision 14e5cc31 | View on GitHub
Set CONTENT_ORIGIN settings
The Travis environment needs content_origin set as a setting.
This also updates the tests to expect Pulp's Distribution.base_url to provide absolute urls.
Required PR: https://github.com/pulp/pulpcore/pull/358 Required PR: https://github.com/PulpQE/pulp-smash/pull/1227 Required PR: https://github.com/pulp/ansible-pulp/pull/185
Added by daviddavis over 4 years ago
Revision 3c35434f | View on GitHub
Removing the content_origin setting since pulp_operator sets it
ref #5629
Required PR: https://github.com/pulp/pulpcore/pull/358 Required PR: https://github.com/PulpQE/pulp-smash/pull/1227
Added by bmbouter over 4 years ago
Revision e8a9176c | View on GitHub
Use CONTENT_ORIGIN instead of CONTENT_HOST
pulpcore changed the setting name from CONTENT_HOST to CONTENT_ORIGIN.
Required PR: https://github.com/pulp/pulpcore/pull/370 Required PR: https://github.com/PulpQE/pulp-smash/pull/1227
Added by bmbouter over 4 years ago
Revision 74acaf3c | View on GitHub
Fix performance tests for CONTENT_ORIGIN
The performance tests now expect an absolute url which is provided thanks to the CONTENT_ORIGIN change.
Updated by bmbouter over 4 years ago
- Status changed from MODIFIED to POST
bringing back to POST for one more PR: https://github.com/pulp/pulp_file/pull/310
Updated by bmbouter over 4 years ago
- Status changed from POST to MODIFIED
Applied in changeset pulp_file:74acaf3c4f679c4e888d18092c2a505764a0e317.
Updated by bmbouter over 4 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
.
Set content_origin automatically
The plugin_template sets
content_originas http://$(hostname):24816`. This aligns with the current way services are tested on Travishttps://pulp.plan.io/issues/5629 re #5629