Project

Profile

Help

Task #5629

Introduce CONTENT_ORIGIN as a required setting

Added by bmbouter about 2 months ago. Updated about 1 month ago.

Status:
MODIFIED
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Platform Release:
Blocks Release:
Backwards Incompatible:
No
Groomed:
No
Sprint Candidate:
No
Tags:
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 61

Description

As discussed on the mailing list we need a new required setting because:

1. plugins like pulp_docker require this CONTENT_HOST to be set, but others may not, so this setting could become a dividing line for plugins that want it set versus those that don't.

2. Clients are semantically unsure how to handle responses for one Pulp server versus another. This setting changes the client's responsibilities (relative vs absolute URL handling).

3. Relative urls are not as usable as absolute urls.

Solution

Add a setting named CONTENT_ORIGIN that is required.


Subtasks

Story #5648: Add CONTENT_ORIGIN to the installerMODIFIED

Actions
Task #5649: Remove CONTENT_HOST from pulpcoreMODIFIED

Actions
Task #5686: Update places in Travis that call 'django-admin runserver'MODIFIEDdaviddavis

Actions

Associated revisions

Revision 0ddeaf33 View on GitHub
Added by bmbouter about 1 month ago

Set content_origin automatically

The plugin_template sets `content_origin` as http://$(hostname):24816`.
This aligns with the current way services are tested on Travis

https://pulp.plan.io/issues/5629
re #5629

Revision c7ee477c View on GitHub
Added by Mike DePaulo about 1 month ago

Set content_origin to the 1st node's 1st address.

If not set by the user.

Limited scope (single-node clusters), but sufficient for
minikube/k3s/our Travis CI.
fixes: #5138
In pulp-operator, the content_origin should be set to the actual accessible service URL
https://pulp.plan.io/issues/5138

re: #5629
[Epic] Introduce CONTENT_ORIGIN as a required setting
https://pulp.plan.io/issues/5629

Revision e027cd3f View on GitHub
Added by bmbouter about 1 month ago

Introduce CONTENT_ORIGIN setting

This also adds a check that the user specified CONTENT_ORIGIN at
startup. Pulp refuses to start if it is not set with an error message
for the user.

Required PR: https://github.com/PulpQE/pulp-smash/pull/1227
Required PR: https://github.com/pulp/ansible-pulp/pull/185
Required PR: https://github.com/pulp/pulp_file/pull/303

https://pulp.plan.io/issues/5629
re #5629

Revision 14e5cc31 View on GitHub
Added by bmbouter about 1 month ago

Set CONTENT_ORIGIN settings

The Travis environment needs `content_origin` set as a setting.

This also updates the tests to expect Pulp's Distribution.base_url to
provide absolute urls.

Required PR: https://github.com/pulp/pulpcore/pull/358
Required PR: https://github.com/PulpQE/pulp-smash/pull/1227
Required PR: https://github.com/pulp/ansible-pulp/pull/185

https://pulp.plan.io/issues/5629
re #5629

Revision 3c35434f View on GitHub
Added by daviddavis about 1 month ago

Removing the content_origin setting since pulp_operator sets it

ref #5629

Required PR: https://github.com/pulp/pulpcore/pull/358
Required PR: https://github.com/PulpQE/pulp-smash/pull/1227

Revision e8a9176c View on GitHub
Added by bmbouter about 1 month ago

Use CONTENT_ORIGIN instead of CONTENT_HOST

pulpcore changed the setting name from CONTENT_HOST to CONTENT_ORIGIN.

Required PR: https://github.com/pulp/pulpcore/pull/370
Required PR: https://github.com/PulpQE/pulp-smash/pull/1227

https://pulp.plan.io/issues/5629
re #5629

Revision 74acaf3c View on GitHub
Added by bmbouter about 1 month ago

Fix performance tests for CONTENT_ORIGIN

The performance tests now expect an absolute url which is provided
thanks to the CONTENT_ORIGIN change.

https://pulp.plan.io/issues/5629
closes #5629

History

#1 Updated by daviddavis about 2 months ago

  • Sprint set to Sprint 61

This is a 3.0 GA blocker. Adding to sprint.

#2 Updated by bmbouter about 2 months ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to bmbouter

#3 Updated by fabricio.aguiar about 1 month ago

  • Tracker changed from Issue to Task
  • % Done set to 0

#4 Updated by bmbouter about 1 month ago

  • Subject changed from Rename CONTENT_HOST to CONTENT_ORIGIN to Introduce CONTENT_ORIGIN as a required setting
  • Description updated (diff)

#5 Updated by bmbouter about 1 month ago

  • Status changed from ASSIGNED to NEW
  • Assignee deleted (bmbouter)

#6 Updated by bmbouter about 1 month ago

  • Subject changed from Introduce CONTENT_ORIGIN as a required setting to [Epic] Introduce CONTENT_ORIGIN as a required setting

#7 Updated by bmbouter about 1 month ago

  • Subject changed from [Epic] Introduce CONTENT_ORIGIN as a required setting to Introduce CONTENT_ORIGIN as a required setting

#8 Updated by daviddavis about 1 month ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to daviddavis

#9 Updated by daviddavis about 1 month ago

  • Status changed from ASSIGNED to MODIFIED

#10 Updated by bmbouter about 1 month ago

  • Status changed from MODIFIED to POST

bringing back to POST for one more PR: https://github.com/pulp/pulp_file/pull/310

#11 Updated by bmbouter about 1 month ago

  • Status changed from POST to MODIFIED

#12 Updated by daviddavis about 1 month ago

  • Status changed from MODIFIED to POST

#13 Updated by daviddavis about 1 month ago

  • Status changed from POST to MODIFIED

Please register to edit this issue

Also available in: Atom PDF