Pulp

Where should we add this check? We could add this check here Or we could check it at end when creating a RepositoryVersion in core here

I think add_content makes the most sense so it can fail fast. I don't have a huge preference though.

I agree, I think add_content should validate its input.

Another option for where to implement it:

Given we have #3541, we could offer the entire repo_key check as a generic implementation that plugins may mix in/derive from/use in their add_content hooks.

This would simplify the add_content implementation in RepositoryVersion.

This is on hold until we figure https://pulp.plan.io/issues/3541 out.

seems the code is prepared to replace content based on repo_key_fields: remove_duplicates: https://github.com/pulp/pulpcore/blob/master/pulpcore/plugin/repo_version_utils.py#L16 test_second_unit_replaces_the_first: https://github.com/pulp/pulp_file/blob/master/pulp_file/tests/functional/api/test_crud_content_unit.py#L264

In [1]: repo = FileRepository.objects.first()  
 
In [2]: repo.content.all()                    
Out[2]: <QuerySet [<Content (pulp_type=file.file): pk=735cbb5a-494c-4f88-9e10-2f85a2a1fb82>, <Content (pulp_type=file.file): pk=208f273c-2035-4863-834d-ecdd98789f55>]>
 
In [3]: [o.content for o in RepositoryVersion.objects.all()]                                  
Out[3]:
[<QuerySet []>,
 <QuerySet [<Content (pulp_type=file.file): pk=208f273c-2035-4863-834d-ecdd98789f55>]>,
 <QuerySet [<Content (pulp_type=file.file): pk=735cbb5a-494c-4f88-9e10-2f85a2a1fb82>]>]

Applied in changeset pulpcore|fd3a2ae9e9244e8bc50492daf7df3da17105ac5d.