Issue #5489
NamePagination mimics PageNumberPagination while it should inherit LimitOffsetPagination
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
API Bindings, Easy Fix
Sprint:
Sprint 60
Quarter:
Description
This leads to inconsistent pagination apis.
See:
https://pulp.plan.io/issues/5324
Maybe it is even possible to inherit from DEFAULT_PAGINATION_CLASS
.
Associated revisions
History
#1
Updated by mdellweg over 1 year ago
It might be even easier to use OrderingFilter
as described here:
https://www.django-rest-framework.org/api-guide/pagination/#configuration_2
#2
Updated by mdellweg over 1 year ago
In case, this is going to be a thing, i have started a PR:
#3
Updated by fao89 over 1 year ago
- Triaged changed from No to Yes
- Sprint set to Sprint 59
#4
Updated by mdellweg over 1 year ago
- Status changed from NEW to POST
#5
Updated by rchan over 1 year ago
- Sprint changed from Sprint 59 to Sprint 60
#6
Updated by mdellweg over 1 year ago
- Status changed from POST to MODIFIED
Applied in changeset pulpcore|85407f155f4c52c1602183af77a8e88319a842b6.
#7
Updated by bmbouter about 1 year ago
- Sprint/Milestone set to 3.0.0
#8
Updated by bmbouter about 1 year ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Please register to edit this issue
Remove NamePagination class
Sorting of the results can be accomplished on the queryset.
fixes #5489 https://pulp.plan.io/issues/5489