Actions
Issue #5489
closed
NamePagination mimics PageNumberPagination while it should inherit LimitOffsetPagination
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
API Bindings, Easy Fix
Sprint:
Sprint 60
Quarter:
Description
This leads to inconsistent pagination apis.
See:
https://pulp.plan.io/issues/5324
Maybe it is even possible to inherit from DEFAULT_PAGINATION_CLASS.
Updated by mdellweg about 5 years ago
It might be even easier to use OrderingFilter as described here:
https://www.django-rest-framework.org/api-guide/pagination/#configuration_2
Updated by mdellweg about 5 years ago
In case, this is going to be a thing, i have started a PR:
Updated by fao89 about 5 years ago
- Triaged changed from No to Yes
- Sprint set to Sprint 59
Added by mdellweg about 5 years ago
Updated by mdellweg about 5 years ago
- Status changed from POST to MODIFIED
Applied in changeset pulpcore|85407f155f4c52c1602183af77a8e88319a842b6.
Updated by bmbouter almost 5 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Updated by bmbouter over 4 years ago
- Category deleted (
14)
We are removing the 'API' category per open floor discussion June 16, 2020.
Actions
.
Remove NamePagination class
Sorting of the results can be accomplished on the queryset.
fixes #5489 https://pulp.plan.io/issues/5489