Project

Profile

Help

Issue #5489

NamePagination mimics PageNumberPagination while it should inherit LimitOffsetPagination

Added by mdellweg 6 months ago. Updated 4 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
-
Category:
API
Sprint/Milestone:
Start date:
Due date:
Severity:
2. Medium
Version:
Platform Release:
Blocks Release:
OS:
Backwards Incompatible:
No
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
API Bindings, Easy Fix
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 60

Description

This leads to inconsistent pagination apis.

See:
https://pulp.plan.io/issues/5324

Maybe it is even possible to inherit from DEFAULT_PAGINATION_CLASS.

Associated revisions

Revision 85407f15 View on GitHub
Added by mdellweg 6 months ago

Remove NamePagination class

Sorting of the results can be accomplished on the queryset.

fixes #5489 https://pulp.plan.io/issues/5489

History

#1 Updated by mdellweg 6 months ago

It might be even easier to use OrderingFilter as described here:
https://www.django-rest-framework.org/api-guide/pagination/#configuration_2

#2 Updated by mdellweg 6 months ago

In case, this is going to be a thing, i have started a PR:

https://github.com/pulp/pulpcore/pull/308

#3 Updated by fabricio.aguiar 6 months ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 59

#4 Updated by mdellweg 6 months ago

  • Status changed from NEW to POST

#5 Updated by rchan 6 months ago

  • Sprint changed from Sprint 59 to Sprint 60

#6 Updated by mdellweg 6 months ago

  • Status changed from POST to MODIFIED

#7 Updated by bmbouter 4 months ago

  • Sprint/Milestone set to 3.0.0

#8 Updated by bmbouter 4 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF