Project

Profile

Help

Issue #5330

closed

Hardcoded URL patterns needs proper check

Added by ppicka about 5 years ago. Updated almost 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 59
Quarter:

Description

As now used urlpatterns check only ending of url :

urlpatterns = [
    url(r'rpm/upload/$', OneShotUploadViewSet.as_view({'post': 'create'})),
    url(r'rpm/copy/$', CopyViewSet.as_view({'post': 'create'})),
    url(r'modulemd/upload/$', ModuleOneShotUpload.as_view({'post': 'create'}))
]

it is possible to use them in strange ways :

http --form POST :24817/pulp/api/v3/sdfghjkl/modulemd/upload/ file@./fedora.yaml.gz

works same as

http --form POST :24817/pulp/api/v3/modulemd/upload/ file@./fedora.yaml.gz

We should allow users to use only one way as other api calls starts with "/pulp/api/v3/..."


Related issues

Related to Container Support - Issue #5486: Plugin url patterns allow an arbitrary base path (not just /pulp/api/v3/)CLOSED - CURRENTRELEASEamacdona@redhat.comActions

Also available in: Atom PDF