Project

Profile

Help

Issue #5486

Plugin url patterns allow an arbitrary base path (not just /pulp/api/v3/)

Added by iballou 2 months ago. Updated about 2 months ago.

Status:
MODIFIED
Priority:
Normal
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Severity:
2. Medium
Version - Docker:
Platform Release:
Blocks Release:
Target Release - Docker:
OS:
Backwards Incompatible:
No
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 59

Description

Original:

In each of their generated docs I noticed the endpoints all looked like

**POST** /docker/blah
instead of
**POST** /pulp/api/v3/blah
. Also, when doing DockerRecursiveAddApi.create I get a 404 and
No route matches [POST] "/docker/recursive-add"
at
lib/pulp_docker_client/api_client.rb:81:in `call_api'

However, it looks like the schema is actually correct, but the urlmatching is not strict enough.

All of these are valid and routed to the same view:

http POST localhost:24817/docker/recursive-add/ repository=/pulp/api/v3/repositories/597c2209-2ff2-4eec-b476-3740ff2879de/
http POST localhost:24817/pulp/api/v3/docker/recursive-add/ repository=/pulp/api/v3/repositories/597c2209-2ff2-4eec-b476-3740ff2879de/
http POST localhost:24817/thanks/for/reading/the/details/docker/recursive-add/ repository=/pulp/api/v3/repositories/597c2209-2ff2-4eec-b476-3740ff2879de/

IIRC, this is actually a deliberate feature of the plugin api, so they can register non-prefixed endpoints like /v2/ for Docker.

This might just be as simple as adding "^pulp/api/v3/" to the start of the urlpatterns, but it will need to be done for any plugins that have implemented custom urls.


Related issues

Related to RPM Support - Issue #5330: Hardcoded URL patterns needs proper check MODIFIED Actions

History

#1 Updated by amacdona@redhat.com 2 months ago

  • Project changed from Docker Support to Pulp
  • Subject changed from DockerRecursiveAdd, DockerRecursiveRemove, and DockerCopy ruby bindings go to the wrong url to Plugin url patterns allow an arbitrary base path (not just /pulp/api/v3/)
  • Description updated (diff)

#2 Updated by amacdona@redhat.com 2 months ago

This seems fixes the issue (forcing the use of /pulp/api/v3/) for pulp_docker. https://github.com/pulp/pulp_docker/pull/415/

#3 Updated by amacdona@redhat.com 2 months ago

  • Description updated (diff)
  • Tags deleted (API Bindings)

#4 Updated by ipanova@redhat.com 2 months ago

  • Related to Issue #5330: Hardcoded URL patterns needs proper check added

#5 Updated by ipanova@redhat.com 2 months ago

  • Status changed from NEW to POST
  • Assignee set to amacdona@redhat.com
  • Sprint set to Sprint 59

#6 Updated by ipanova@redhat.com 2 months ago

  • Triaged changed from No to Yes

#7 Updated by ipanova@redhat.com 2 months ago

  • Project changed from Pulp to Docker Support

I am moving this back to docker since we fixed this only in docker plugin, other plugins would need to submit separate PRs and/or issues

#8 Updated by ipanova@redhat.com about 2 months ago

  • Status changed from POST to MODIFIED

Please register to edit this issue

Also available in: Atom PDF