Actions
Issue #4600
closedDockerDistributions are not validated correctly
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 51
Quarter:
Description
After fixing, the following tests should pass:
One test should probably be deleted instead of passing:
It might be possible that the fix could be made to pulpcore's BaseDistributionSerializer. If so, that would be ideal.
Actions
Problem: BaseDistribution.validate() is too Distribution specific
Solution: Move validate() to the Distribution instead
This patch allows classes that inherit from BaseDistribution to call super().validate(data) to get the validation provided by the ModelSerializer.
This patch also removes base_path from BaseDistribution because it is defined on the Distribution. DockerDistribution also defines it for itself.
re: #4669 https://pulp.plan.io/issues/4669