Issue #4600
closedDockerDistributions are not validated correctly
Description
After fixing, the following tests should pass:
One test should probably be deleted instead of passing:
It might be possible that the fix could be made to pulpcore's BaseDistributionSerializer. If so, that would be ideal.
Added by dkliban@redhat.com over 5 years ago
Added by dkliban@redhat.com over 5 years ago
Revision 202d3cdf | View on GitHub
Problem: Publications are not needed for Docker plugin
Solution: Add 'repository_version' field to DockerDistribution
This patch allows users to create DockerDistributions that serve repository versions. A distribution can be created with either a repository or repository version defined. If a repository is defined, the latest version of that repository is always available at the distribution. If a repository version is specified, then that repository version is always available at that distribution.
This patch updates an existing test and adds a new one. The two tests assert that a docker or podman pull can be performed when a repository is used in a distribution and when a repository version is used.
This patch also fixes the tests to work with docker as the client.
Updated by dkliban@redhat.com over 5 years ago
- Status changed from NEW to MODIFIED
- Assignee set to dkliban@redhat.com
Updated by dkliban@redhat.com over 5 years ago
Updated by dkliban@redhat.com over 5 years ago
- Status changed from MODIFIED to ASSIGNED
Added by dkliban@redhat.com over 5 years ago
Revision edc0d9b0 | View on GitHub
Problem: DockerDistribution name field not validated correctly
Solution: Define the name field on the DockerDistribution serializer
The name field from the BaseDistribution serializer validates that the name doesn't collide with any other Distributions.
Added by dkliban@redhat.com over 5 years ago
Revision edc0d9b0 | View on GitHub
Problem: DockerDistribution name field not validated correctly
Solution: Define the name field on the DockerDistribution serializer
The name field from the BaseDistribution serializer validates that the name doesn't collide with any other Distributions.
Added by dkliban@redhat.com over 5 years ago
Revision edc0d9b0 | View on GitHub
Problem: DockerDistribution name field not validated correctly
Solution: Define the name field on the DockerDistribution serializer
The name field from the BaseDistribution serializer validates that the name doesn't collide with any other Distributions.
Added by dkliban@redhat.com over 5 years ago
Revision edc0d9b0 | View on GitHub
Problem: DockerDistribution name field not validated correctly
Solution: Define the name field on the DockerDistribution serializer
The name field from the BaseDistribution serializer validates that the name doesn't collide with any other Distributions.
Updated by dkliban@redhat.com over 5 years ago
- Status changed from ASSIGNED to MODIFIED
Applied in changeset commit:pulp_docker|edc0d9b0c66218119efc81b710b287dbccc8d0f2.
Updated by dkliban@redhat.com over 5 years ago
Applied in changeset edc0d9b0c66218119efc81b710b287dbccc8d0f2.
Updated by ipanova@redhat.com about 5 years ago
- Project changed from Docker Support to Container Support
Updated by ipanova@redhat.com about 5 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Problem: BaseDistribution.validate() is too Distribution specific
Solution: Move validate() to the Distribution instead
This patch allows classes that inherit from BaseDistribution to call super().validate(data) to get the validation provided by the ModelSerializer.
This patch also removes base_path from BaseDistribution because it is defined on the Distribution. DockerDistribution also defines it for itself.
re: #4669 https://pulp.plan.io/issues/4669