Project

Profile

Help

Issue #4600

DockerDistributions are not validated correctly

Added by amacdona@redhat.com over 1 year ago. Updated 9 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 51
Quarter:

Associated revisions

Revision a9fdc824 View on GitHub
Added by dkliban@redhat.com over 1 year ago

Problem: BaseDistribution.validate() is too Distribution specific

Solution: Move validate() to the Distribution instead

This patch allows classes that inherit from BaseDistribution to call super().validate(data) to get the validation provided by the ModelSerializer.

This patch also removes base_path from BaseDistribution because it is defined on the Distribution. DockerDistribution also defines it for itself.

re: #4669 https://pulp.plan.io/issues/4669

Revision 202d3cdf View on GitHub
Added by dkliban@redhat.com over 1 year ago

Problem: Publications are not needed for Docker plugin

Solution: Add 'repository_version' field to DockerDistribution

This patch allows users to create DockerDistributions that serve repository versions. A distribution can be created with either a repository or repository version defined. If a repository is defined, the latest version of that repository is always available at the distribution. If a repository version is specified, then that repository version is always available at that distribution.

This patch updates an existing test and adds a new one. The two tests assert that a docker or podman pull can be performed when a repository is used in a distribution and when a repository version is used.

This patch also fixes the tests to work with docker as the client.

closes: #4669 https://pulp.plan.io/issues/4669

Revision edc0d9b0 View on GitHub
Added by dkliban@redhat.com over 1 year ago

Problem: DockerDistribution name field not validated correctly

Solution: Define the name field on the DockerDistribution serializer

The name field from the BaseDistribution serializer validates that the name doesn't collide with any other Distributions.

closes: #4600 https://pulp.plan.io/issues/4600

Revision edc0d9b0 View on GitHub
Added by dkliban@redhat.com over 1 year ago

Problem: DockerDistribution name field not validated correctly

Solution: Define the name field on the DockerDistribution serializer

The name field from the BaseDistribution serializer validates that the name doesn't collide with any other Distributions.

closes: #4600 https://pulp.plan.io/issues/4600

Revision edc0d9b0 View on GitHub
Added by dkliban@redhat.com over 1 year ago

Problem: DockerDistribution name field not validated correctly

Solution: Define the name field on the DockerDistribution serializer

The name field from the BaseDistribution serializer validates that the name doesn't collide with any other Distributions.

closes: #4600 https://pulp.plan.io/issues/4600

Revision edc0d9b0 View on GitHub
Added by dkliban@redhat.com over 1 year ago

Problem: DockerDistribution name field not validated correctly

Solution: Define the name field on the DockerDistribution serializer

The name field from the BaseDistribution serializer validates that the name doesn't collide with any other Distributions.

closes: #4600 https://pulp.plan.io/issues/4600

History

#1 Updated by ipanova@redhat.com over 1 year ago

  • Triaged changed from No to Yes

#2 Updated by ipanova@redhat.com over 1 year ago

  • Sprint set to Sprint 51

#3 Updated by dkliban@redhat.com over 1 year ago

  • Status changed from NEW to MODIFIED
  • Assignee set to dkliban@redhat.com

#5 Updated by dkliban@redhat.com over 1 year ago

  • Status changed from MODIFIED to ASSIGNED

#6 Updated by dkliban@redhat.com over 1 year ago

  • Status changed from ASSIGNED to MODIFIED

Applied in changeset commit:pulp_docker|edc0d9b0c66218119efc81b710b287dbccc8d0f2.

#8 Updated by bmbouter over 1 year ago

  • Tags deleted (Pulp 3)

#9 Updated by ipanova@redhat.com 11 months ago

  • Project changed from Docker Support to Container Support

#10 Updated by ipanova@redhat.com 11 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

#11 Updated by ipanova@redhat.com 9 months ago

  • Sprint/Milestone set to 1.0.0

Please register to edit this issue

Also available in: Atom PDF