Project

Profile

Help

Actions
Send by e-mail Copy link

Refactor #4567

closed

Convert data between createrepo_c format and pulp format in a unified way

Added by ttereshc over 5 years ago. Updated about 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
ppicka
Sprint/Milestone:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
No
Tags:
Sprint:
Sprint 55
Quarter:

Description

There are few issues which inspired that refactor task:
- null value can come from creatrepo_c while in TextField it's recommended to use empty string in such cases https://pulp.plan.io/issues/4502
- more complicated structures which Pulp stores in a TextField requires serialization/deserialization (or maybe remodelling to make them simpler) https://github.com/pulp/pulp_rpm/pull/1298#discussion_r265235083
- there are two ways to get content into Pulp: via sync and via upload. And RPM plugin processes data differently in those cases, e.g. at upload time there is some data JSON serialization is happening, no serialization happens at sync time.

In general, if it's possible to isolate createrepo_c specifics (not only data conversion), code would be much better organized and readable.

Actions
Copy link
 #1

Updated by ttereshc over 5 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by dalley over 5 years ago

  • Groomed changed from No to Yes
Actions
Copy link
 #3

Updated by ttereshc over 5 years ago

  • Sprint set to Sprint 51
Actions
Copy link
 #4

Updated by daviddavis over 5 years ago

  • Sprint changed from Sprint 51 to Sprint 52
Actions
Copy link
 #5

Updated by bmbouter over 5 years ago

  • Tags deleted (Pulp 3)
Actions
Copy link
 #6

Updated by rchan over 5 years ago

  • Sprint changed from Sprint 52 to Sprint 53
Actions
Copy link
 #7

Updated by ppicka over 5 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ppicka
Actions
Copy link
 #8

Updated by amacdona@redhat.com over 5 years ago

  • Sprint changed from Sprint 53 to Sprint 54
Actions
Copy link
 #9

Updated by Anonymous over 5 years ago

  • File clipboard-201906201006-ofmgl.png added
Actions
Copy link
 #10

Updated by Anonymous over 5 years ago

  • File clipboard-201906201006-fi9lh.png added
  • File clipboard-201906201006-9jece.png added
Actions
Copy link
 #11

Updated by ppicka over 5 years ago

  • File deleted (clipboard-201906201006-ofmgl.png)
Actions
Copy link
 #12

Updated by ppicka over 5 years ago

  • File deleted (clipboard-201906201006-fi9lh.png)
Actions
Copy link
 #13

Updated by ppicka over 5 years ago

  • File deleted (clipboard-201906201006-9jece.png)

Added by ppicka over 5 years ago

Revision e871d21a | View on GitHub

Refactor naming for pakcage attr

to better readability code package method to convert data to createrepo_c using PULP namespace.

closes: #4567 https://pulp.plan.io/issues/4567

Signed-off-by: Pavel Picka

Actions
Copy link
 #14

Updated by ttereshc over 5 years ago

  • Sprint changed from Sprint 54 to Sprint 55
Actions
Copy link
 #15

Updated by ppicka over 5 years ago

  • Status changed from ASSIGNED to POST
Actions
Copy link
 #16

Updated by ppicka over 5 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions
Copy link
 #17

Updated by ttereshc about 5 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Send by e-mail Copy link

Also available in: Atom PDF