Project

Profile

Help

Issue #4384

closed

Pulp Crane not returning correct headers

Added by paji@redhat.com about 5 years ago. Updated almost 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version - Docker:
Platform Release:
2.19.0
Target Release - Docker:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Sprint 49
Quarter:

Description

Sync the following docker repo
feed: https://quay.io/
upstream_name: openshift-release-dev/ocp-release

Pulp Crane

Check out the following output when syncing v1 content

$ curl --head -L https://<fqdn>:5000/v2/default_organization-custom-ocp/manifests/4.0.0-0
HTTP/1.1 302 FOUND
Date: Mon, 04 Feb 2019 16:29:14 GMT
Server: Apache/2.4.6 (Red Hat Enterprise Linux)
Content-Length: 437
Location: https://<fqdn>/pulp/docker/v2/fe117c3c-5820-4406-ad34-8404062b8458/manifests/1/4.0.0-0
Content-Type: text/html; charset=utf-8

HTTP/1.1 200 OK
Date: Mon, 04 Feb 2019 16:29:15 GMT
Server: Apache/2.4.6 (Red Hat Enterprise Linux)
Last-Modified: Wed, 30 Jan 2019 16:28:40 GMT
ETag: "e5e-580af6711a0c7"
Accept-Ranges: bytes
Content-Length: 3678
Docker-Distribution-API-Version: registry/2.0

Quay:
Now compare it to the same in quay

$ curl --head -L https://quay.io/v2/coreos/etcd/manifests/latest
HTTP/2 200
server: nginx/1.14.2
date: Mon, 04 Feb 2019 16:29:41 GMT
content-type: application/vnd.docker.distribution.manifest.v1+prettyjws
content-length: 6655
docker-content-digest: sha256:5b6691b7225a3f77a5a919a81261bbfb31283804418e187f7116a0a9ef65d21d
x-frame-options: DENY
strict-transport-security: max-age=63072000; preload

Notice how content-type is set to application/vnd.docker.distribution.manifest.v1+prettyjws in the case of quay, while its blank for pulp-crane.

This causes issues in clients pulling this information.


Related issues

Copied to Docker Support - Test #4535: Pulp Crane not returning correct headersCLOSED - COMPLETEbherringActions
Actions #1

Updated by daviddavis about 5 years ago

  • Project changed from Infrastructure to Docker Support
Actions #2

Updated by ipanova@redhat.com about 5 years ago

Some investigation was done: grc registry cannot hangle unsigned manifest, docker registry always signes the manifest before returning, that said, we can assume that signed schema1 manifest is in circulation.

Apache config needs to be updated to return mediatype of a signed manifest for schema1.

https://github.com/pulp/pulp_docker/blob/2-master/plugins/etc/httpd/conf.d/pulp_docker.conf#L18

Actions #3

Updated by dkliban@redhat.com about 5 years ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 49

Added by ipanova@redhat.com about 5 years ago

Revision 27ae9fc6 | View on GitHub

Update apache confing to return signed schema1 mediatype.

closes #4364 https://pulp.plan.io/issues/4384

Actions #4

Updated by ipanova@redhat.com about 5 years ago

  • Status changed from NEW to POST
  • Assignee set to ipanova@redhat.com
Actions #5

Updated by ipanova@redhat.com about 5 years ago

  • Status changed from POST to MODIFIED
Actions #6

Updated by bherring about 5 years ago

  • Copied to Test #4535: Pulp Crane not returning correct headers added
Actions #7

Updated by ttereshc about 5 years ago

  • Platform Release set to 2.19.0
Actions #8

Updated by ttereshc about 5 years ago

  • Sprint/Milestone set to 2.19.0
Actions #9

Updated by ttereshc about 5 years ago

  • Status changed from MODIFIED to 5
Actions #10

Updated by ttereshc about 5 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE
Actions #11

Updated by bmbouter almost 5 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF