Project

Profile

Help

Issue #4384

Pulp Crane not returning correct headers

Added by paji@redhat.com 10 months ago. Updated 7 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Category:
-
Sprint/Milestone:
Start date:
Due date:
Severity:
2. Medium
Version - Docker:
Platform Release:
2.19.0
Blocks Release:
Target Release - Docker:
OS:
Backwards Incompatible:
No
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 49

Description

Sync the following docker repo
feed: https://quay.io/
upstream_name: openshift-release-dev/ocp-release

Pulp Crane

Check out the following output when syncing v1 content

$ curl --head -L https://<fqdn>:5000/v2/default_organization-custom-ocp/manifests/4.0.0-0
HTTP/1.1 302 FOUND
Date: Mon, 04 Feb 2019 16:29:14 GMT
Server: Apache/2.4.6 (Red Hat Enterprise Linux)
Content-Length: 437
Location: https://<fqdn>/pulp/docker/v2/fe117c3c-5820-4406-ad34-8404062b8458/manifests/1/4.0.0-0
Content-Type: text/html; charset=utf-8

HTTP/1.1 200 OK
Date: Mon, 04 Feb 2019 16:29:15 GMT
Server: Apache/2.4.6 (Red Hat Enterprise Linux)
Last-Modified: Wed, 30 Jan 2019 16:28:40 GMT
ETag: "e5e-580af6711a0c7" 
Accept-Ranges: bytes
Content-Length: 3678
Docker-Distribution-API-Version: registry/2.0

Quay:
Now compare it to the same in quay

$ curl --head -L https://quay.io/v2/coreos/etcd/manifests/latest
HTTP/2 200
server: nginx/1.14.2
date: Mon, 04 Feb 2019 16:29:41 GMT
content-type: application/vnd.docker.distribution.manifest.v1+prettyjws
content-length: 6655
docker-content-digest: sha256:5b6691b7225a3f77a5a919a81261bbfb31283804418e187f7116a0a9ef65d21d
x-frame-options: DENY
strict-transport-security: max-age=63072000; preload

Notice how content-type is set to application/vnd.docker.distribution.manifest.v1+prettyjws in the case of quay, while its blank for pulp-crane.

This causes issues in clients pulling this information.


Related issues

Copied to Docker Support - Test #4535: Pulp Crane not returning correct headers CLOSED - COMPLETE Actions

Associated revisions

Revision 27ae9fc6 View on GitHub
Added by ipanova@redhat.com 9 months ago

Update apache confing to return signed schema1 mediatype.

closes #4364
https://pulp.plan.io/issues/4384

History

#1 Updated by daviddavis 9 months ago

  • Project changed from Infrastructure to Docker Support

#2 Updated by ipanova@redhat.com 9 months ago

Some investigation was done: grc registry cannot hangle unsigned manifest, docker registry always signes the manifest before returning, that said, we can assume that signed schema1 manifest is in circulation.

Apache config needs to be updated to return mediatype of a signed manifest for schema1.

https://github.com/pulp/pulp_docker/blob/2-master/plugins/etc/httpd/conf.d/pulp_docker.conf#L18

#3 Updated by dkliban@redhat.com 9 months ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 49

#4 Updated by ipanova@redhat.com 9 months ago

  • Status changed from NEW to POST
  • Assignee set to ipanova@redhat.com

#5 Updated by ipanova@redhat.com 9 months ago

  • Status changed from POST to MODIFIED

#6 Updated by bherring 8 months ago

  • Copied to Test #4535: Pulp Crane not returning correct headers added

#7 Updated by ttereshc 8 months ago

  • Platform Release set to 2.19.0

#8 Updated by ttereshc 8 months ago

  • Sprint/Milestone set to 2.19.0

#9 Updated by ttereshc 8 months ago

  • Status changed from MODIFIED to ON_QA

#10 Updated by ttereshc 8 months ago

  • Status changed from ON_QA to CLOSED - CURRENTRELEASE

#11 Updated by bmbouter 7 months ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF