Pulp

This looks great. For whoever takes this role, please have a look at the tools installed, it has become somewhat bloated IMO.

There are some tools that are pretty much required for development, (httpie is used in our documentation, for example). Please just bring over the tools that everyone will use. For bonus points, maybe add a new config value "pulp_devel_extra_packages: []" that will allow each dev to specify whatever they want without slowing down everyone else's installation.

I had done a few minutes on this in November and I had these changes:

[bmbouter@localhost ansible-pulp3]$ git diff
diff --git a/roles/pulp3/defaults/main.yml b/roles/pulp3/defaults/main.yml
index a13a30f..7498515 100644
--- a/roles/pulp3/defaults/main.yml
+++ b/roles/pulp3/defaults/main.yml
@@ -6,6 +6,7 @@ pulp_default_admin_password: ''
 pulp_install_dir: '/usr/local/lib/pulp'
 pulp_install_plugins: {}
 pulp_install_wsgi_service: true
+pulp_create_user: true
 pulp_user: pulp
 pulp_var_dir: '/var/lib/pulp'
 pulp_wsgi_enabled: true
diff --git a/roles/pulp3/tasks/install.yml b/roles/pulp3/tasks/install.yml
index 2e59abd..26e89fa 100644
--- a/roles/pulp3/tasks/install.yml
+++ b/roles/pulp3/tasks/install.yml
@@ -28,8 +28,8 @@
       user:
         name: '{{ pulp_user }}'
         shell: '{{ result.stdout.strip() }}'
-        home: '{{ pulp_var_dir }}'
         system: true
+      when: pulp_create_user == true

     - name: Create temp dir for Pulp
       file:
diff --git a/source-install.yml b/source-install.yml
index 307ecb4..038bbb4 100644
--- a/source-install.yml
+++ b/source-install.yml
@@ -3,6 +3,8 @@
   vars:
     pulp_source_dir: "/home/vagrant/devel/pulp"
     pulp_secret_key: "unsafe_default"
+    pulp_user: "vagrant"
+    pulp_create_user: false
     pulp_default_admin_password: password
     pulp_install_plugins:
       # pulp-python:

Another suggestion is to install pulp-smash in the dev box, allowing to run functional tests locally before push to CI.

Assuming that a virtualenv called pulp available.

pip install git+https://github.com/PulpQE/pulp-smash.git#egg=pulp-smash