Project

Profile

Help

Task #4234

closed

Switch devel environment to use pulplift

Added by dkliban@redhat.com almost 4 years ago. Updated over 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
Installer - Moved to GitHub issues
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Dev Environment
Sprint:
Sprint 47
Quarter:

Description

A 'pulp3-devel' role needs to be added to the ansibl-pulp3 repository[0]. This role needs to install all the same packages that are currently installed by the 'dev_tools' role[1] in the 'devel' repo. The new role should also add all the same bash aliases and config files as done by 'pulp-user' role[2] in the 'devel' repo.

The 'source-install.yml' playbook[3] needs to be updated to include the new 'pulp3-devel' role.

The developer setup guide[4] needs to be updated to tell the user to use pulplift. The documentation should provide information about how to select which plugins get installed by modifying the source-install.yml playbook.

[0] https://github.com/pulp/ansible-pulp3
[1] https://github.com/pulp/devel/tree/master/ansible/roles/dev_tools/
[2] https://github.com/pulp/devel/tree/master/ansible/roles/pulp-user
[3] https://github.com/pulp/ansible-pulp3/blob/master/source-install.yml
[4] https://docs.pulpproject.org/en/3.0/nightly/contributing/dev-setup/index.html

Actions #1

Updated by dkliban@redhat.com almost 4 years ago

  • Description updated (diff)
Actions #2

Updated by dkliban@redhat.com almost 4 years ago

  • Description updated (diff)
Actions #3

Updated by amacdona@redhat.com almost 4 years ago

This looks great. For whoever takes this role, please have a look at the tools installed, it has become somewhat bloated IMO.

There are some tools that are pretty much required for development, (httpie is used in our documentation, for example). Please just bring over the tools that everyone will use. For bonus points, maybe add a new config value "pulp_devel_extra_packages: []" that will allow each dev to specify whatever they want without slowing down everyone else's installation.

Actions #4

Updated by amacdona@redhat.com almost 4 years ago

  • Groomed changed from No to Yes
  • Tags Dev Environment, Pulp 3 installer added
Actions #5

Updated by CodeHeeler almost 4 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to CodeHeeler
Actions #6

Updated by rchan almost 4 years ago

  • Sprint set to Sprint 47

Will contribute to good developer experience and a good deliverable by the next plugin writers workshop in early February.

Actions #7

Updated by bmbouter almost 4 years ago

I had done a few minutes on this in November and I had these changes:

[bmbouter@localhost ansible-pulp3]$ git diff
diff --git a/roles/pulp3/defaults/main.yml b/roles/pulp3/defaults/main.yml
index a13a30f..7498515 100644
--- a/roles/pulp3/defaults/main.yml
+++ b/roles/pulp3/defaults/main.yml
@@ -6,6 +6,7 @@ pulp_default_admin_password: ''
 pulp_install_dir: '/usr/local/lib/pulp'
 pulp_install_plugins: {}
 pulp_install_wsgi_service: true
+pulp_create_user: true
 pulp_user: pulp
 pulp_var_dir: '/var/lib/pulp'
 pulp_wsgi_enabled: true
diff --git a/roles/pulp3/tasks/install.yml b/roles/pulp3/tasks/install.yml
index 2e59abd..26e89fa 100644
--- a/roles/pulp3/tasks/install.yml
+++ b/roles/pulp3/tasks/install.yml
@@ -28,8 +28,8 @@
       user:
         name: '{{ pulp_user }}'
         shell: '{{ result.stdout.strip() }}'
-        home: '{{ pulp_var_dir }}'
         system: true
+      when: pulp_create_user == true

     - name: Create temp dir for Pulp
       file:
diff --git a/source-install.yml b/source-install.yml
index 307ecb4..038bbb4 100644
--- a/source-install.yml
+++ b/source-install.yml
@@ -3,6 +3,8 @@
   vars:
     pulp_source_dir: "/home/vagrant/devel/pulp"
     pulp_secret_key: "unsafe_default"
+    pulp_user: "vagrant"
+    pulp_create_user: false
     pulp_default_admin_password: password
     pulp_install_plugins:
       # pulp-python:

Added by CodeHeeler almost 4 years ago

Revision 51e455cc

Switch devel environment to use pulplift

Added pulp3-devel role to the ansible-pulp3 repo

re #4234 https://pulp.plan.io/issues/4234

Added by CodeHeeler almost 4 years ago

Revision 51e455cc

Switch devel environment to use pulplift

Added pulp3-devel role to the ansible-pulp3 repo

re #4234 https://pulp.plan.io/issues/4234

Actions #8

Updated by kersom almost 4 years ago

Another suggestion is to install pulp-smash in the dev box, allowing to run functional tests locally before push to CI.

Assuming that a virtualenv called pulp available.

pip install git+https://github.com/PulpQE/pulp-smash.git#egg=pulp-smash

Added by CodeHeeler almost 4 years ago

Revision 95496049

Update vagrant boxes to use SSHFS

Use SSHFS to mount source code from the host onto the vagrant box. This is part of the update to create pulp3 devel environment w/ pulplift.

re #4234 https://pulp.plan.io/issues/4234

Added by CodeHeeler almost 4 years ago

Revision b8ab4d32

Cleanup unused items for pulplift, added docs reqs

Switching devel environment to use pulplift first focused on hooking up, now focusing on cleaning up unused changes along the way or unwanted items. Added doc building requirements

re #4234 https://pulp.plan.io/issues/4234

Added by CodeHeeler almost 4 years ago

Revision b8ab4d32

Cleanup unused items for pulplift, added docs reqs

Switching devel environment to use pulplift first focused on hooking up, now focusing on cleaning up unused changes along the way or unwanted items. Added doc building requirements

re #4234 https://pulp.plan.io/issues/4234

Added by CodeHeeler almost 4 years ago

Revision cc9fa8f0

Updating Developer Setup Guide to use Pulplift

Instructs the developer to setup their environment with Pulplift

re #4234 https://pulp.plan.io/issues/4234

Added by CodeHeeler almost 4 years ago

Revision cc9fa8f0

Updating Developer Setup Guide to use Pulplift

Instructs the developer to setup their environment with Pulplift

re #4234 https://pulp.plan.io/issues/4234

Actions #10

Updated by CodeHeeler almost 4 years ago

  • Status changed from POST to MODIFIED
Actions #11

Updated by daviddavis over 3 years ago

  • Sprint/Milestone set to 3.0.0
Actions #12

Updated by bmbouter over 3 years ago

  • Tags deleted (Pulp 3)
Actions #13

Updated by bmbouter almost 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions #14

Updated by bmbouter over 2 years ago

  • Category set to Installer - Moved to GitHub issues
  • Tags deleted (Pulp 3 installer)

Also available in: Atom PDF