Actions
Task #4114
closedRename Remote.connection_limit to Remote.download_concurrency
Start date:
Due date:
% Done:
100%
Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Sprint:
Sprint 46
Quarter:
Description
Background¶
The concurrency limiting feature is now present in BaseDownloader which means that all downloaders could support concurrency restriction correctly. The HttpDownloader and FileDownloader both do.
The issue¶
When a setting like Remote.connection_limit is applied to a FileDownloader the name "connection_limit" makes no sense. File I/O has no connections at all, but it does have a notion of concurrency.
Solution¶
Rename the 'connection_limit' to 'download_concurrency' throughout the codebase and comments in the codebase.
@dkliban suggested the name 'download_concurrency'
Related issues
Actions
Rename connection_limit to download_concurrency
Rename the 'connection_limit' to 'download_concurrency' throughout the codebase and comments in the codebase to variable name to be more understandable.
re: #4114 https://pulp.plan.io/issues/4114
Required PR: https://github.com/pulp/pulpcore-plugin/pull/23
Signed-off-by: Pavel Picka ppicka@redhat.com