Task #4114
closed
Rename Remote.connection_limit to Remote.download_concurrency
100%
Description
Background¶
The concurrency limiting feature is now present in BaseDownloader which means that all downloaders could support concurrency restriction correctly. The HttpDownloader and FileDownloader both do.
The issue¶
When a setting like Remote.connection_limit is applied to a FileDownloader the name "connection_limit" makes no sense. File I/O has no connections at all, but it does have a notion of concurrency.
Solution¶
Rename the 'connection_limit' to 'download_concurrency' throughout the codebase and comments in the codebase.
@dkliban suggested the name 'download_concurrency'
Related issues
Updated by bmbouter about 6 years ago
- Related to Test #4115: Functionally test downloader concurrency restriction added
Updated by ppicka about 6 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to ppicka
Added by ppicka about 6 years ago
Added by ppicka about 6 years ago
Revision 9166d985 | View on GitHub
Rename connection_limit to download_concurrency
Rename the 'connection_limit' to 'download_concurrency' throughout the codebase and comments in the codebase to variable name to be more understandable.
re: #4114 https://pulp.plan.io/issues/4114
Required PR: https://github.com/pulp/pulpcore-plugin/pull/23
Signed-off-by: Pavel Picka ppicka@redhat.com
Updated by ppicka about 6 years ago
- Status changed from ASSIGNED to POST
found only in pulp and pulpcore-plugins from list [devel, pulp, pulp_ansible, pulp_docker, pulp_file, pulp_python, pulp_rpm, pulpcore-plugin]
POST: https://github.com/pulp/pulpcore-plugin/pull/23 & https://github.com/pulp/pulp/pull/3808
Updated by ppicka about 6 years ago
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
Applied in changeset commit:pulpcore-plugin|9105b104ff60dd26183663586990fb421ccc6130.
Updated by bmbouter about 5 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
.
Rename connection_limit to download_concurrency
Rename the 'connection_limit' to 'download_concurrency' throughout the codebase and comments in the codebase to variable name to be more understandable.
re: #4114 https://pulp.plan.io/issues/4114
Required PR: https://github.com/pulp/pulpcore-plugin/pull/23
Signed-off-by: Pavel Picka ppicka@redhat.com