Project

Profile

Help

Task #4114

Rename Remote.connection_limit to Remote.download_concurrency

Added by bmbouter almost 2 years ago. Updated 9 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Sprint:
Sprint 46
Quarter:

Description

Background

The concurrency limiting feature is now present in BaseDownloader which means that all downloaders could support concurrency restriction correctly. The HttpDownloader and FileDownloader both do.

The issue

When a setting like Remote.connection_limit is applied to a FileDownloader the name "connection_limit" makes no sense. File I/O has no connections at all, but it does have a notion of concurrency.

Solution

Rename the 'connection_limit' to 'download_concurrency' throughout the codebase and comments in the codebase.

@dkliban suggested the name 'download_concurrency'


Related issues

Related to Pulp - Test #4115: Functionally test downloader concurrency restrictionCLOSED - WONTFIX<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

Associated revisions

Revision 9166d985 View on GitHub
Added by ppicka almost 2 years ago

Rename connection_limit to download_concurrency

Rename the 'connection_limit' to 'download_concurrency' throughout the codebase and comments in the codebase to variable name to be more understandable.

re: #4114 https://pulp.plan.io/issues/4114

Required PR: https://github.com/pulp/pulpcore-plugin/pull/23

Signed-off-by: Pavel Picka

Revision 9166d985 View on GitHub
Added by ppicka almost 2 years ago

Rename connection_limit to download_concurrency

Rename the 'connection_limit' to 'download_concurrency' throughout the codebase and comments in the codebase to variable name to be more understandable.

re: #4114 https://pulp.plan.io/issues/4114

Required PR: https://github.com/pulp/pulpcore-plugin/pull/23

Signed-off-by: Pavel Picka

History

#1 Updated by bmbouter almost 2 years ago

  • Related to Test #4115: Functionally test downloader concurrency restriction added

#2 Updated by dkliban@redhat.com almost 2 years ago

  • Groomed changed from No to Yes

#3 Updated by dkliban@redhat.com almost 2 years ago

  • Sprint set to Sprint 45

#4 Updated by rchan almost 2 years ago

  • Sprint changed from Sprint 45 to Sprint 46

#5 Updated by ppicka almost 2 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ppicka

#6 Updated by ppicka almost 2 years ago

  • Status changed from ASSIGNED to POST

found only in pulp and pulpcore-plugins from list [devel, pulp, pulp_ansible, pulp_docker, pulp_file, pulp_python, pulp_rpm, pulpcore-plugin]
POST: https://github.com/pulp/pulpcore-plugin/pull/23 & https://github.com/pulp/pulp/pull/3808

#7 Updated by ppicka almost 2 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

Applied in changeset commit:pulpcore-plugin|9105b104ff60dd26183663586990fb421ccc6130.

#8 Updated by daviddavis over 1 year ago

  • Sprint/Milestone set to 3.0.0

#9 Updated by bmbouter over 1 year ago

  • Tags deleted (Pulp 3)

#10 Updated by bmbouter 9 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF