Project

Profile

Help

Task #4114

Rename Remote.connection_limit to Remote.download_concurrency

Added by bmbouter 12 months ago. Updated 6 months ago.

Status:
MODIFIED
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Platform Release:
Blocks Release:
Backwards Incompatible:
No
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 46

Description

Background

The concurrency limiting feature is now present in BaseDownloader which means that all downloaders could support concurrency restriction correctly. The HttpDownloader and FileDownloader both do.

The issue

When a setting like Remote.connection_limit is applied to a FileDownloader the name "connection_limit" makes no sense. File I/O has no connections at all, but it does have a notion of concurrency.

Solution

Rename the 'connection_limit' to 'download_concurrency' throughout the codebase and comments in the codebase.

@dkliban suggested the name 'download_concurrency'


Related issues

Related to Pulp - Test #4115: Functionally test downloader concurrency restriction NEW Actions

Associated revisions

Revision 9166d985 View on GitHub
Added by ppicka 10 months ago

Rename connection_limit to download_concurrency

Rename the 'connection_limit' to 'download_concurrency'
throughout the codebase and comments in the codebase to
variable name to be more understandable.

re: #4114
https://pulp.plan.io/issues/4114

Required PR: https://github.com/pulp/pulpcore-plugin/pull/23

Signed-off-by: Pavel Picka <>

Revision 9166d985 View on GitHub
Added by ppicka 10 months ago

Rename connection_limit to download_concurrency

Rename the 'connection_limit' to 'download_concurrency'
throughout the codebase and comments in the codebase to
variable name to be more understandable.

re: #4114
https://pulp.plan.io/issues/4114

Required PR: https://github.com/pulp/pulpcore-plugin/pull/23

Signed-off-by: Pavel Picka <>

Revision 9105b104 View on GitHub
Added by ppicka 10 months ago

Rename connection_limit to download_concurrency

Rename the 'connection_limit' to 'download_concurrency'
throughout the codebase and comments in the codebase to
variable name to be more understandable.

closes: #4114
https://pulp.plan.io/issues/4114

Required PR: https://github.com/pulp/pulp/pull/3808

Signed-off-by: Pavel Picka <>

History

#1 Updated by bmbouter 12 months ago

  • Related to Test #4115: Functionally test downloader concurrency restriction added

#2 Updated by dkliban@redhat.com 12 months ago

  • Groomed changed from No to Yes

#3 Updated by dkliban@redhat.com 12 months ago

  • Sprint set to Sprint 45

#4 Updated by rchan 11 months ago

  • Sprint changed from Sprint 45 to Sprint 46

#5 Updated by ppicka 10 months ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ppicka

#6 Updated by ppicka 10 months ago

  • Status changed from ASSIGNED to POST

found only in pulp and pulpcore-plugins from list [devel, pulp, pulp_ansible, pulp_docker, pulp_file, pulp_python, pulp_rpm, pulpcore-plugin]
POST: https://github.com/pulp/pulpcore-plugin/pull/23 & https://github.com/pulp/pulp/pull/3808

#7 Updated by ppicka 10 months ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#8 Updated by daviddavis 6 months ago

  • Sprint/Milestone set to 3.0

#9 Updated by bmbouter 6 months ago

  • Tags deleted (Pulp 3)

Please register to edit this issue

Also available in: Atom PDF