Issue #3395
closedRequire `url` on Remotes
Added by daviddavis over 6 years ago. Updated almost 5 years ago.
Description
We don't require url on remotes but when you try to sync an remote without a url, you get a 400 error. Why don't we just require the field on remotes?
Updated by amacdona@redhat.com over 6 years ago
Importers can be for more than just syncing repositories. For instance, plugins might want to use an importer for a rich copy, but that importer may not need a feed_url.
Updated by daviddavis over 6 years ago
- Project changed from Pulp to File Support
Updated by ipanova@redhat.com over 6 years ago
This could be solved by validating the presence of the field feed_url before triggering the sync.
Updated by amacdona@redhat.com over 6 years ago
ipanova@redhat.com wrote:
This could be solved by validating the presence of the field feed_url before triggering the sync.
That is currently how it is done. https://github.com/pulp/pulp_file/blob/master/pulp_file/app/tasks/synchronizing.py#L52
Since this is no longer a Pulp issue, and is a pulp_file issue, the file plugin has no use for importers that don't have a feed_url, so I am +1 on accepting this.
Updated by daviddavis over 6 years ago
- Subject changed from Consider requiring feed_url on importers to Consider requiring feed_url on file importers
Updated by amacdona@redhat.com over 6 years ago
- Project changed from File Support to Pulp
- Subject changed from Consider requiring feed_url on file importers to Require `url` on Remotes
- Groomed changed from No to Yes
- Sprint Candidate changed from No to Yes
Updated by daviddavis over 6 years ago
- Description updated (diff)
- Tags Easy Fix added
Changed importers to remotes.
Updated by amacdona@redhat.com over 6 years ago
- Sprint set to Sprint 35
Please file issues for pulp_python and pulp_file to remove the validation at sync task creation time.
Updated by dalley over 6 years ago
Wait, why was this converted back to a pulp issue from a pulp_file issue? This isn't something we're planning to do in core.
A pulp_python issue should still be filed but this should remain a pulp_file issue.
Updated by amacdona@redhat.com over 6 years ago
With the change from "importer" to "remote" we were thinking that a remote is nothing without a url.
Updated by daviddavis over 6 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to daviddavis
Added by daviddavis over 6 years ago
Updated by daviddavis over 6 years ago
- Status changed from ASSIGNED to POST
Updated by daviddavis over 6 years ago
- Status changed from POST to MODIFIED
Applied in changeset pulp|82b2a80c7d49233969968950b0946bf9b65c17a3.
Added by daviddavis over 6 years ago
Revision 5de1c1b4 | View on GitHub
Remote url no longer needs to be validated before sync
Updated by bmbouter almost 5 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Remote url no longer needs to be validated before sync
ref #3395 https://pulp.plan.io/issues/3395