Project

Profile

Help

Issue #3395

Require `url` on Remotes

Added by daviddavis over 1 year ago. Updated 6 months ago.

Status:
MODIFIED
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Severity:
2. Medium
Version:
Platform Release:
Blocks Release:
OS:
Backwards Incompatible:
No
Triaged:
Yes
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Easy Fix
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 35

Description

We don't require url on remotes but when you try to sync an remote without a url, you get a 400 error. Why don't we just require the field on remotes?

Associated revisions

Revision 3fd99a06 View on GitHub
Added by daviddavis over 1 year ago

Remote url no longer needs to be validated before sync

ref #3395
https://pulp.plan.io/issues/3395

Revision 5de1c1b4 View on GitHub
Added by daviddavis over 1 year ago

Remote url no longer needs to be validated before sync

ref #3395
https://pulp.plan.io/issues/3395

History

#1 Updated by daviddavis over 1 year ago

  • Tags Pulp 3, Pulp 3 MVP added

#2 Updated by amacdona@redhat.com over 1 year ago

Importers can be for more than just syncing repositories. For instance, plugins might want to use an importer for a rich copy, but that importer may not need a feed_url.

#3 Updated by daviddavis over 1 year ago

  • Project changed from Pulp to File Support

#4 Updated by ipanova@redhat.com over 1 year ago

This could be solved by validating the presence of the field feed_url before triggering the sync.

#5 Updated by amacdona@redhat.com over 1 year ago

wrote:

This could be solved by validating the presence of the field feed_url before triggering the sync.

That is currently how it is done. https://github.com/pulp/pulp_file/blob/master/pulp_file/app/tasks/synchronizing.py#L52

Since this is no longer a Pulp issue, and is a pulp_file issue, the file plugin has no use for importers that don't have a feed_url, so I am +1 on accepting this.

#6 Updated by dalley over 1 year ago

  • Triaged changed from No to Yes

#7 Updated by daviddavis over 1 year ago

  • Subject changed from Consider requiring feed_url on importers to Consider requiring feed_url on file importers

#8 Updated by amacdona@redhat.com over 1 year ago

  • Project changed from File Support to Pulp
  • Subject changed from Consider requiring feed_url on file importers to Require `url` on Remotes
  • Groomed changed from No to Yes
  • Sprint Candidate changed from No to Yes

#9 Updated by milan over 1 year ago

maybe s/importers/remotes/ but still LGTM

#10 Updated by daviddavis over 1 year ago

  • Description updated (diff)
  • Tags Easy Fix added

Changed importers to remotes.

#11 Updated by amacdona@redhat.com over 1 year ago

  • Sprint set to Sprint 35

Please file issues for pulp_python and pulp_file to remove the validation at sync task creation time.

#12 Updated by dalley over 1 year ago

Wait, why was this converted back to a pulp issue from a pulp_file issue? This isn't something we're planning to do in core.

A pulp_python issue should still be filed but this should remain a pulp_file issue.

#13 Updated by amacdona@redhat.com over 1 year ago

With the change from "importer" to "remote" we were thinking that a remote is nothing without a url.

#14 Updated by daviddavis over 1 year ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to daviddavis

#16 Updated by daviddavis over 1 year ago

  • Status changed from POST to MODIFIED

#17 Updated by dkliban@redhat.com over 1 year ago

  • Sprint/Milestone set to 3.0

#18 Updated by bmbouter 6 months ago

  • Tags deleted (Pulp 3, Pulp 3 MVP)

Please register to edit this issue

Also available in: Atom PDF