Task #2784
closed
Pulp spec file does not contain a proper Source0
0%
Description
As it stands Pulp and Pulp plugins spec files do not contain correct Source0 URLs. This is in part because the releases have their git tag in the tarfile name hosted on github. I am proposing changing this so that the Source0 leads to the source and renames it to the expected name.
EG:
Currently Pulp-2.12.2 Source0 leads to:
https://github.com/pulp/pulp/archive/pulp-2.12.2.tar.gz
The change will have it go to:
https://codeload.github.com/pulp/pulp/tar.gz/pulp-2.12.2-1#/pulp-2.12.2.tar.gz
which will download the file and rename it to: pulp-2.12.2.tar.gz
Added by zhunting over 6 years ago
Added by zhunting over 6 years ago
Revision e322ac3e | View on GitHub
Update spec files Source0
The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.
Added by zhunting over 6 years ago
Revision bf6ef1dc | View on GitHub
Update spec files Source0
The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.
Added by zhunting over 6 years ago
Revision ccb8ff73 | View on GitHub
Update spec files Source0
The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.
Added by zhunting over 6 years ago
Revision f92440c6 | View on GitHub
Update spec files Source0
The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.
Added by zhunting over 6 years ago
Revision d70c8f92 | View on GitHub
Update spec files Source0
The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.
Added by zhunting over 6 years ago
Revision 32e65c20 | View on GitHub
Update spec files Source0
The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.
Added by zhunting over 6 years ago
Revision 14d581ee | View on GitHub
Update spec files Source0
The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.
Added by zhunting over 6 years ago
Revision 14d581ee | View on GitHub
Update spec files Source0
The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.
Added by zhunting over 6 years ago
Revision 14d581ee | View on GitHub
Update spec files Source0
The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.
Added by zhunting over 6 years ago
Revision 14d581ee | View on GitHub
Update spec files Source0
The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.
Updated by bmbouter over 6 years ago
I'm not familiar with codeload.github.com. Indeed the url you show https://github.com/pulp/pulp/archive/pulp-2.12.2.tar.gz does 404. For that same example I thought it would be this URL: https://github.com/pulp/pulp/archive/pulp-2.12.2-1.tar.gz.
Also the spec file forms the URL from variables. So I think just having a release version variable is all we need to do.
At the same time upstream releases don't really have a release field so maybe the tags in github just have the wrong names.
Updated by ttereshc over 6 years ago
Updated by ttereshc over 6 years ago
- Status changed from NEW to POST
- Triaged changed from No to Yes
Updated by pcreech over 6 years ago
- Tracker changed from Issue to Task
- Status changed from 5 to CLOSED - COMPLETE
- % Done set to 0
Updated by pcreech over 6 years ago
- Status changed from CLOSED - COMPLETE to CLOSED - CURRENTRELEASE
.
Update spec files Source0
The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.
ref #2784 https://pulp.plan.io/issues/2784