Project

Profile

Help

Task #2784

Pulp spec file does not contain a proper Source0

Added by zhunting over 4 years ago. Updated almost 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
2.14.0
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

As it stands Pulp and Pulp plugins spec files do not contain correct Source0 URLs. This is in part because the releases have their git tag in the tarfile name hosted on github. I am proposing changing this so that the Source0 leads to the source and renames it to the expected name.

EG:

Currently Pulp-2.12.2 Source0 leads to:
https://github.com/pulp/pulp/archive/pulp-2.12.2.tar.gz

The change will have it go to:
https://codeload.github.com/pulp/pulp/tar.gz/pulp-2.12.2-1#/pulp-2.12.2.tar.gz

which will download the file and rename it to: pulp-2.12.2.tar.gz

Associated revisions

Revision 51a60b1f View on GitHub
Added by zhunting over 4 years ago

Update spec files Source0

The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.

ref #2784 https://pulp.plan.io/issues/2784

Revision e322ac3e View on GitHub
Added by zhunting over 4 years ago

Update spec files Source0

The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.

ref #2784 https://pulp.plan.io/issues/2784

Revision bf6ef1dc View on GitHub
Added by zhunting over 4 years ago

Update spec files Source0

The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.

ref #2784 https://pulp.plan.io/issues/2784

Revision ccb8ff73 View on GitHub
Added by zhunting over 4 years ago

Update spec files Source0

The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.

ref #2784 https://pulp.plan.io/issues/2784

Revision f92440c6 View on GitHub
Added by zhunting over 4 years ago

Update spec files Source0

The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.

ref #2784 https://pulp.plan.io/issues/2784

Revision d70c8f92 View on GitHub
Added by zhunting over 4 years ago

Update spec files Source0

The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.

ref #2784 https://pulp.plan.io/issues/2784

Revision 32e65c20 View on GitHub
Added by zhunting over 4 years ago

Update spec files Source0

The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.

ref #2784 https://pulp.plan.io/issues/2784

Revision 14d581ee View on GitHub
Added by zhunting over 4 years ago

Update spec files Source0

The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.

ref #2784 https://pulp.plan.io/issues/2784

Revision 14d581ee View on GitHub
Added by zhunting over 4 years ago

Update spec files Source0

The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.

ref #2784 https://pulp.plan.io/issues/2784

Revision 14d581ee View on GitHub
Added by zhunting over 4 years ago

Update spec files Source0

The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.

ref #2784 https://pulp.plan.io/issues/2784

Revision 14d581ee View on GitHub
Added by zhunting over 4 years ago

Update spec files Source0

The Source0 currently does not lead to the correct source file. This updates the spec file and renames the source to what would be the expected source name.

ref #2784 https://pulp.plan.io/issues/2784

History

#1 Updated by bmbouter over 4 years ago

I'm not familiar with codeload.github.com. Indeed the url you show https://github.com/pulp/pulp/archive/pulp-2.12.2.tar.gz does 404. For that same example I thought it would be this URL: https://github.com/pulp/pulp/archive/pulp-2.12.2-1.tar.gz.

Also the spec file forms the URL from variables. So I think just having a release version variable is all we need to do.

At the same time upstream releases don't really have a release field so maybe the tags in github just have the wrong names.

#4 Updated by ttereshc over 4 years ago

  • Status changed from NEW to POST
  • Triaged changed from No to Yes

#5 Updated by ttereshc over 4 years ago

  • Assignee set to zhunting

#6 Updated by pcreech over 4 years ago

  • Status changed from POST to MODIFIED

#7 Updated by pcreech over 4 years ago

  • Platform Release set to 2.14.0

#8 Updated by pcreech over 4 years ago

  • Status changed from MODIFIED to 5

#9 Updated by pcreech over 4 years ago

  • Tracker changed from Issue to Task
  • Status changed from 5 to CLOSED - COMPLETE
  • % Done set to 0

#10 Updated by pcreech over 4 years ago

  • Status changed from CLOSED - COMPLETE to CLOSED - CURRENTRELEASE

#11 Updated by bmbouter almost 3 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF