Project

Profile

Help

Issue #2769

closed

Relative paths are not checked for collisions

Added by Ichimonji10 almost 7 years ago. Updated about 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
High
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
3. High
Version - OSTree:
Platform Release:
2.14.0
Target Release - OSTree:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Sprint 20
Quarter:

Description

An OSTree distributor may be given a relative_path option. All relative paths among all OSTree distributors must be unique. For example, if an OSTree distributor has a relative path of: foo/bar, then the following relative paths are valid:

  • abc/def (unique)
  • ghi/jkl/mno (relative paths aren't restricted to two segments)

And the following relative paths are invalid:

  • foo/bar (identical to an existing relative path)
  • foo/bar/biz (has the same prefix as an existing relative path)
  • /foo/bar (prefixing a slash doesn't change the semantics of the path)

This behaviour has been enforced since Pulp 2.8.3. The work was tracked in Pulp issue #1106 . As of last night's Pulp 2.14 nightly build, the behaviour is no longer enforced. AFAICT, this is a regression.

I could find no messages of interest in journalctl's output.

This issue is present on all 2.14 nightly builds. Here's the relevant packages installed on Fedora 24:

# rpm -qa | grep -i pulp | sort
pulp-admin-client-2.14.0-0.1.alpha.git.18832.aaaae1e.fc24.noarch
pulp-docker-admin-extensions-2.5.0-0.1.alpha.git.268.50ca9b6.fc24.noarch
pulp-docker-plugins-2.5.0-0.1.alpha.git.268.50ca9b6.fc24.noarch
pulp-ostree-admin-extensions-1.3.0-0.1.alpha.git.191.ad58669.fc24.noarch
pulp-ostree-plugins-1.3.0-0.1.alpha.git.191.ad58669.fc24.noarch
pulp-puppet-admin-extensions-2.14.0-0.1.alpha.git.373.251928b.fc24.noarch
pulp-puppet-plugins-2.14.0-0.1.alpha.git.373.251928b.fc24.noarch
pulp-python-admin-extensions-2.1.0-0.1.alpha.git.166.6ad0f43.fc24.noarch
pulp-python-plugins-2.1.0-0.1.alpha.git.166.6ad0f43.fc24.noarch
pulp-rpm-admin-extensions-2.14.0-0.1.alpha.git.833.a2a7e39.fc24.noarch
pulp-rpm-plugins-2.14.0-0.1.alpha.git.833.a2a7e39.fc24.noarch
pulp-selinux-2.14.0-0.1.alpha.git.18832.aaaae1e.fc24.noarch
pulp-server-2.14.0-0.1.alpha.git.18832.aaaae1e.fc24.noarch
python-kombu-3.0.33-6.pulp.fc24.noarch
python-pulp-bindings-2.14.0-0.1.alpha.git.18832.aaaae1e.fc24.noarch
python-pulp-client-lib-2.14.0-0.1.alpha.git.18832.aaaae1e.fc24.noarch
python-pulp-common-2.14.0-0.1.alpha.git.18832.aaaae1e.fc24.noarch
python-pulp-docker-common-2.5.0-0.1.alpha.git.268.50ca9b6.fc24.noarch
python-pulp-oid_validation-2.14.0-0.1.alpha.git.18832.aaaae1e.fc24.noarch
python-pulp-ostree-common-1.3.0-0.1.alpha.git.191.ad58669.fc24.noarch
python-pulp-puppet-common-2.14.0-0.1.alpha.git.373.251928b.fc24.noarch
python-pulp-python-common-2.1.0-0.1.alpha.git.166.6ad0f43.fc24.noarch
python-pulp-repoauth-2.14.0-0.1.alpha.git.18832.aaaae1e.fc24.noarch
python-pulp-rpm-common-2.14.0-0.1.alpha.git.833.a2a7e39.fc24.noarch
python-pulp-streamer-2.14.0-0.1.alpha.git.18832.aaaae1e.fc24.noarch

Also available in: Atom PDF