Project

Profile

Help

Task #2728

Check and fix Pulp compatibility with python-mongoengine >= 0.11.0 in Fedora 26/Rawhide

Added by ttereshc over 4 years ago. Updated almost 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
2.13.2
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Pulp 2
Sprint:
Sprint 20
Quarter:

Description

According to mongoengine changelog there are several breaking changes introduced in 0.11.0 and in 0.12.0.
It looks to me that at least ConnectionError exception renaming is an issue (it is used here), maybe something else as well, investigation needed.

We currently ship python-mongoengine 0.10.5, f24/25 - 0.10.6, f26 - 0.11.0, rawhide - 0.12.0.
Pulp currently requires python-mongoengine >= 0.10.0.

Also worth noticing, 0.11.0 drops python 2.6 support.

Associated revisions

Revision 84fcc192 View on GitHub
Added by ipanova@redhat.com over 4 years ago

Make Pulp compatible with mongoengine 0.10+

closes #2728 https://pulp.plan.io/issues/2728

History

#1 Updated by ttereshc over 4 years ago

  • Description updated (diff)

#2 Updated by ttereshc over 4 years ago

It looks like 0.10.6 is available in F26, but in Rawhide there is 0.12.0 only so far.
So setting python-mongoengine version < 0.11.0 will work for F26.

We still have to decide what to do for Rawhide, ship old version on our own or modify Pulp code.

#3 Updated by bmbouter over 4 years ago

This is an important piece of work and the story is very well written, thank you for writing it up. I have two questions.

My main question is: Can Pulp remain compatible with 0.10.z+ without having a bunch of if blocks all over the codebase? The way the checklist and task is written now suggests that we will become compatible with 0.11+ which will be an issue for downstream usages of Pulp because 0.11 drops Python 2.6 support and those environments still use Python 2.6. I think this can only be answered during the investigation part of the task so I've added a checklist item to make a decision about what we support based on how easily easily maintain 0.10.z+ compatibility all the way through 0.12.z.

My lesser question is: If we do need to build python-mongoengine 0.11 for F24 and F25, would we build it both in koji.katello and koji.fedorapeople? The speed of delivery is affected by when/where we need the dep available, which is probably impacted by the choice of versions we can feasibly support. I made that checklist item more vague because if we can have 0.10+ support then we don't need to build anything.

#4 Updated by ttereshc over 4 years ago

+ 1 for trying to make Pulp compatible with 0.10.0+.
Thanks for modifications in checklist.

#5 Updated by bmbouter over 4 years ago

  • Groomed changed from No to Yes
  • Sprint Candidate changed from No to Yes

I think this story is functionally complete so I'm going to groom it.

#6 Updated by jortel@redhat.com over 4 years ago

  • Sprint/Milestone set to 38

#7 Updated by ipanova@redhat.com over 4 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ipanova@redhat.com

#8 Updated by ipanova@redhat.com over 4 years ago

  • Status changed from ASSIGNED to POST

Latest version in fedora is 0.12, on pypi 0.13.
I checked the changelog up to 0.13 including.

http://docs.mongoengine.org/changelog.html#changes-in-0-13-0

The only breaking change that affects us is renamed ConnectionError to MongoEngineConnectionError

https://github.com/pulp/pulp/pull/3024

#9 Updated by mhrivnak over 4 years ago

  • Sprint/Milestone changed from 38 to 39

#10 Updated by ipanova@redhat.com over 4 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#11 Updated by pcreech over 4 years ago

  • Platform Release set to 2.13.2

#12 Updated by pcreech over 4 years ago

  • Status changed from MODIFIED to 5

#13 Updated by pcreech over 4 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE

#14 Updated by bmbouter almost 4 years ago

  • Sprint set to Sprint 20

#15 Updated by bmbouter almost 4 years ago

  • Sprint/Milestone deleted (39)

#16 Updated by bmbouter almost 3 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF