Refactor #2658
Update Pulp's apply_async function signature to conform with Celery's
100%
Description
Currently pulp's apply_async function signature[0] does not explicitly match Celery's [1]
This has caused some confusion over what to pass to Pulp's apply_async [2]
Refactoring our apply_async signature to take in the keyword arguments 'args' and 'kwargs' may be ugly, but it does explicitly state that these are the arguments that Celery passes to a task. It also allows us to distinguish between the arguments for celery, and the arguments for our task.
We should also document how to kick off Pulp3 apply_async and apply_async_with_reservations tasks in a blog post
[0] https://github.com/pulp/pulp/blob/3.0-dev/tasking/pulp/tasking/tasks.py#L211
[1] http://docs.celeryproject.org/en/latest/reference/celery.app.task.html#celery.app.task.Task.apply_async
[2] https://github.com/pulp/pulp/pull/2971
Associated revisions
Revision 4518a20a
View on GitHub
Update apply_async and apply_async_with_reservations signatures
History
#1
Updated by dkliban@redhat.com almost 4 years ago
- Groomed changed from No to Yes
- Sprint Candidate changed from No to Yes
#2
Updated by mhrivnak almost 4 years ago
- Sprint/Milestone set to 37
#3
Updated by bizhang almost 4 years ago
Documentation for running apply_async and apply_async_with_reservation is now in the pulp wiki https://pulp.plan.io/projects/pulp/wiki/Pulp_3_Developer_Notes
#4
Updated by fdobrovo almost 4 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to fdobrovo
#5
Updated by ttereshc over 3 years ago
- Status changed from ASSIGNED to POST
#6
Updated by jortel@redhat.com over 3 years ago
- Sprint/Milestone changed from 37 to 38
#7
Updated by mhrivnak over 3 years ago
- Sprint/Milestone changed from 38 to 39
#8
Updated by fdobrovo over 3 years ago
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
Applied in changeset pulp|4518a20a0ff124fbd8069f4ce9378386279d0782.
#9
Updated by bmbouter almost 3 years ago
- Sprint set to Sprint 20
#10
Updated by bmbouter almost 3 years ago
- Sprint/Milestone deleted (
39)
#11
Updated by daviddavis almost 2 years ago
- Sprint/Milestone set to 3.0.0
#12
Updated by bmbouter almost 2 years ago
- Tags deleted (
Pulp 3)
#13
Updated by bmbouter about 1 year ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Please register to edit this issue
Update apply_async and apply_async_with_reservations signatures
closes #2658 https://pulp.plan.io/issues/2658