Project

Profile

Help

Refactor #2658

closed

Update Pulp's apply_async function signature to conform with Celery's

Added by bizhang about 7 years ago. Updated over 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Sprint:
Sprint 20
Quarter:

Description

Currently pulp's apply_async function signature[0] does not explicitly match Celery's [1]
This has caused some confusion over what to pass to Pulp's apply_async [2]

Refactoring our apply_async signature to take in the keyword arguments 'args' and 'kwargs' may be ugly, but it does explicitly state that these are the arguments that Celery passes to a task. It also allows us to distinguish between the arguments for celery, and the arguments for our task.

We should also document how to kick off Pulp3 apply_async and apply_async_with_reservations tasks in a blog post

[0] https://github.com/pulp/pulp/blob/3.0-dev/tasking/pulp/tasking/tasks.py#L211
[1] http://docs.celeryproject.org/en/latest/reference/celery.app.task.html#celery.app.task.Task.apply_async
[2] https://github.com/pulp/pulp/pull/2971

Actions #1

Updated by dkliban@redhat.com almost 7 years ago

  • Groomed changed from No to Yes
  • Sprint Candidate changed from No to Yes
Actions #2

Updated by mhrivnak almost 7 years ago

  • Sprint/Milestone set to 37
Actions #3

Updated by bizhang almost 7 years ago

Documentation for running apply_async and apply_async_with_reservation is now in the pulp wiki https://pulp.plan.io/projects/pulp/wiki/Pulp_3_Developer_Notes

Actions #4

Updated by fdobrovo almost 7 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to fdobrovo
Actions #5

Updated by ttereshc almost 7 years ago

  • Status changed from ASSIGNED to POST
Actions #6

Updated by jortel@redhat.com almost 7 years ago

  • Sprint/Milestone changed from 37 to 38
Actions #7

Updated by mhrivnak almost 7 years ago

  • Sprint/Milestone changed from 38 to 39

Added by fdobrovo almost 7 years ago

Revision 4518a20a | View on GitHub

Update apply_async and apply_async_with_reservations signatures

closes #2658 https://pulp.plan.io/issues/2658

Added by fdobrovo almost 7 years ago

Revision 4518a20a | View on GitHub

Update apply_async and apply_async_with_reservations signatures

closes #2658 https://pulp.plan.io/issues/2658

Actions #8

Updated by fdobrovo almost 7 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions #9

Updated by bmbouter about 6 years ago

  • Sprint set to Sprint 20
Actions #10

Updated by bmbouter about 6 years ago

  • Sprint/Milestone deleted (39)
Actions #11

Updated by daviddavis almost 5 years ago

  • Sprint/Milestone set to 3.0.0
Actions #12

Updated by bmbouter almost 5 years ago

  • Tags deleted (Pulp 3)
Actions #13

Updated by bmbouter over 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF