Project

Profile

Help

Task #2286

Add a travis task to fail when the plugin imports anything from pulp that isn't pulpcore.plugin

Added by semyers about 4 years ago. Updated over 1 year ago.

Status:
NEW
Priority:
Normal
Assignee:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
Tags:
Sprint:
Quarter:

Description

While planning for pulp 3, we generally agreed that any plugin importing from anywhere other than 'pulpcore.plugin' indicates a failure of the plugin API. Based on this, it might be handy to have travis checking import statements in plugins to warn us when plugins are importing from inappropriate pulp platform namespaces.

History

#1 Updated by semyers almost 4 years ago

For this, I was thinking it might be easy to implement a flake8 plugin, since it's already got the static code analysis capabilities.

#2 Updated by semyers almost 4 years ago

  • Sprint Candidate changed from No to Yes

#3 Updated by mhrivnak almost 4 years ago

  • Groomed changed from No to Yes

#4 Updated by fdobrovo over 3 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to fdobrovo

#5 Updated by daviddavis almost 3 years ago

  • Sprint/Milestone set to 52

#6 Updated by ttereshc over 2 years ago

  • Status changed from ASSIGNED to NEW
  • Assignee deleted (fdobrovo)

#7 Updated by rchan over 2 years ago

  • Sprint/Milestone changed from 52 to 53

#8 Updated by bmbouter over 2 years ago

  • Subject changed from Add a travis task to fail when plugins import anything from pulp that isn't pulp.plugin to Add a travis task to fail when plugins import anything from pulp that isn't pulpcore.plugin
  • Description updated (diff)

Updated to reflect the Python package name used.

#9 Updated by jortel@redhat.com over 2 years ago

  • Sprint/Milestone changed from 53 to 54

#10 Updated by jortel@redhat.com over 2 years ago

  • Sprint/Milestone deleted (54)

#11 Updated by daviddavis over 2 years ago

  • Project changed from Pulp to File Support

#12 Updated by amacdona@redhat.com over 2 years ago

  • Subject changed from Add a travis task to fail when plugins import anything from pulp that isn't pulpcore.plugin to Add a travis task to fail when the plugin imports anything from pulp that isn't pulpcore.plugin

#13 Updated by daviddavis over 2 years ago

  • Sprint Candidate deleted (Yes)

#14 Updated by bmbouter over 1 year ago

  • Tags deleted (Pulp 3)

Please register to edit this issue

Also available in: Atom PDF