Project

Profile

Help

Task #2286

closed

Add a travis task to fail when the plugin imports anything from pulp that isn't pulpcore.plugin

Added by semyers over 7 years ago. Updated over 2 years ago.

Status:
CLOSED - DUPLICATE
Priority:
Normal
Assignee:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
Tags:
Sprint:
Quarter:

Description

Ticket moved to GitHub: "pulp/pulp_file/603":https://github.com/pulp/pulp_file/issues/603


While planning for pulp 3, we generally agreed that any plugin importing from anywhere other than 'pulpcore.plugin' indicates a failure of the plugin API. Based on this, it might be handy to have travis checking import statements in plugins to warn us when plugins are importing from inappropriate pulp platform namespaces.

Actions #1

Updated by semyers over 7 years ago

For this, I was thinking it might be easy to implement a flake8 plugin, since it's already got the static code analysis capabilities.

Actions #2

Updated by semyers over 7 years ago

  • Sprint Candidate changed from No to Yes
Actions #3

Updated by mhrivnak over 7 years ago

  • Groomed changed from No to Yes
Actions #4

Updated by fdobrovo almost 7 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to fdobrovo
Actions #5

Updated by daviddavis over 6 years ago

  • Sprint/Milestone set to 52
Actions #6

Updated by ttereshc over 6 years ago

  • Status changed from ASSIGNED to NEW
  • Assignee deleted (fdobrovo)
Actions #7

Updated by rchan over 6 years ago

  • Sprint/Milestone changed from 52 to 53
Actions #8

Updated by bmbouter over 6 years ago

  • Subject changed from Add a travis task to fail when plugins import anything from pulp that isn't pulp.plugin to Add a travis task to fail when plugins import anything from pulp that isn't pulpcore.plugin
  • Description updated (diff)

Updated to reflect the Python package name used.

Actions #9

Updated by jortel@redhat.com about 6 years ago

  • Sprint/Milestone changed from 53 to 54
Actions #10

Updated by jortel@redhat.com about 6 years ago

  • Sprint/Milestone deleted (54)
Actions #11

Updated by daviddavis about 6 years ago

  • Project changed from Pulp to File Support
Actions #12

Updated by amacdona@redhat.com about 6 years ago

  • Subject changed from Add a travis task to fail when plugins import anything from pulp that isn't pulpcore.plugin to Add a travis task to fail when the plugin imports anything from pulp that isn't pulpcore.plugin
Actions #13

Updated by daviddavis about 6 years ago

  • Sprint Candidate deleted (Yes)
Actions #14

Updated by bmbouter almost 5 years ago

  • Tags deleted (Pulp 3)
Actions #15

Updated by pulpbot over 2 years ago

  • Description updated (diff)
  • Status changed from NEW to CLOSED - DUPLICATE

Also available in: Atom PDF