Task #2286
closed
Add a travis task to fail when the plugin imports anything from pulp that isn't pulpcore.plugin
Status:
CLOSED - DUPLICATE
Description
Ticket moved to GitHub: "pulp/pulp_file/603":https://github.com/pulp/pulp_file/issues/603
While planning for pulp 3, we generally agreed that any plugin importing from anywhere other than 'pulpcore.plugin' indicates a failure of the plugin API. Based on this, it might be handy to have travis checking import statements in plugins to warn us when plugins are importing from inappropriate pulp platform namespaces.
For this, I was thinking it might be easy to implement a flake8 plugin, since it's already got the static code analysis capabilities.
- Sprint Candidate changed from No to Yes
- Groomed changed from No to Yes
- Status changed from NEW to ASSIGNED
- Assignee set to fdobrovo
- Sprint/Milestone set to 52
- Status changed from ASSIGNED to NEW
- Assignee deleted (
fdobrovo)
- Sprint/Milestone changed from 52 to 53
- Subject changed from Add a travis task to fail when plugins import anything from pulp that isn't pulp.plugin to Add a travis task to fail when plugins import anything from pulp that isn't pulpcore.plugin
- Description updated (diff)
Updated to reflect the Python package name used.
- Sprint/Milestone changed from 53 to 54
- Sprint/Milestone deleted (
54)
- Project changed from Pulp to File Support
- Subject changed from Add a travis task to fail when plugins import anything from pulp that isn't pulpcore.plugin to Add a travis task to fail when the plugin imports anything from pulp that isn't pulpcore.plugin
- Sprint Candidate deleted (
Yes)
- Description updated (diff)
- Status changed from NEW to CLOSED - DUPLICATE
Also available in: Atom
PDF