Project

Profile

Help

Refactor #2156

Convert pulp_celerybeat to use a django lock model

Added by mhrivnak over 3 years ago. Updated 7 months ago.

Status:
MODIFIED
Priority:
Normal
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Platform Release:
Blocks Release:
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Complexity:
Verified:
No
Verification Required:
No
Sprint:
Sprint 9

Description

pulp_celerybeat currently uses a mongodb collection with a uniqueness constraint to obtain a lock. Multiple processes attempt to insert a document, and the one who succeeds is the active process.

Given the lock model that has already been created in django, convert pulp_celerybeat to use it instead of the mongo model.

It's important to test that these locks are acquired and released as expected. Hand testing this by manually invoking two pulp_celerybeats and testing failover would be good.


Checklist


Related issues

Blocked by Pulp - Refactor #2087: create django models for task system MODIFIED Actions

Associated revisions

Revision 6e81d8d7 View on GitHub
Added by fdobrovo about 3 years ago

Convert pulp_resource_manager to use a django lock model

closes #2156
https://pulp.plan.io/issues/2156

Revision 6e81d8d7 View on GitHub
Added by fdobrovo about 3 years ago

Convert pulp_resource_manager to use a django lock model

closes #2156
https://pulp.plan.io/issues/2156

Revision 365f9fd0 View on GitHub
Added by dkliban@redhat.com about 3 years ago

Removes database backed celerybeat schedule

This change also converts worker watcher to use Django. This patch renames the scheduler to pulp_celerybeat.

closes: #2158
https://pulp.plan.io/issues/2158
closes: #2156
https://pulp.plan.io/issues/2156
closes: #1978
https://pulp.plan.io/issues/1978

blah

Revision 365f9fd0 View on GitHub
Added by dkliban@redhat.com about 3 years ago

Removes database backed celerybeat schedule

This change also converts worker watcher to use Django. This patch renames the scheduler to pulp_celerybeat.

closes: #2158
https://pulp.plan.io/issues/2158
closes: #2156
https://pulp.plan.io/issues/2156
closes: #1978
https://pulp.plan.io/issues/1978

blah

Revision 365f9fd0 View on GitHub
Added by dkliban@redhat.com about 3 years ago

Removes database backed celerybeat schedule

This change also converts worker watcher to use Django. This patch renames the scheduler to pulp_celerybeat.

closes: #2158
https://pulp.plan.io/issues/2158
closes: #2156
https://pulp.plan.io/issues/2156
closes: #1978
https://pulp.plan.io/issues/1978

blah

History

#1 Updated by mhrivnak over 3 years ago

  • Blocked by Refactor #2087: create django models for task system added

#2 Updated by mhrivnak over 3 years ago

  • Project changed from RPM Support to Pulp

#3 Updated by mhrivnak over 3 years ago

  • Tags Pulp 3 added

#4 Updated by bmbouter over 3 years ago

  • Checklist item convert the pulp resource manager to use the Django based model added
  • Description updated (diff)
  • Groomed changed from No to Yes

#5 Updated by mhrivnak over 3 years ago

  • Checklist item changed from convert the pulp resource manager to use the Django based model to convert pulp_celerybeat to use the Django based model

#6 Updated by mhrivnak over 3 years ago

  • Sprint/Milestone set to 25

#7 Updated by mhrivnak over 3 years ago

  • Sprint/Milestone changed from 25 to 26

#8 Updated by dkliban@redhat.com about 3 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to dkliban@redhat.com

#9 Updated by mhrivnak about 3 years ago

  • Sprint/Milestone changed from 26 to 27

#10 Updated by fdobrovo about 3 years ago

  • Status changed from ASSIGNED to MODIFIED
  • % Done changed from 0 to 100

#11 Updated by fdobrovo about 3 years ago

  • Status changed from MODIFIED to ASSIGNED

I accidently have written a wrong number to commit https://github.com/pulp/pulp/commit/6e81d8d723144c586933192754b8d99fe8af3414 #2156 instead of #2157. So the commit belongs to #2157!! Sorry...

#12 Updated by dkliban@redhat.com about 3 years ago

  • Status changed from ASSIGNED to POST

#13 Updated by dkliban@redhat.com about 3 years ago

  • Status changed from POST to MODIFIED

#14 Updated by bmbouter over 1 year ago

  • Sprint set to Sprint 9

#15 Updated by bmbouter over 1 year ago

  • Sprint/Milestone deleted (27)

#16 Updated by daviddavis 7 months ago

  • Sprint/Milestone set to 3.0

#17 Updated by bmbouter 7 months ago

  • Tags deleted (Pulp 3)

Please register to edit this issue

Also available in: Atom PDF