Project

Profile

Help

Refactor #2158

Remove pulp_celerybeat use of scheduled calls from database

Added by mhrivnak about 3 years ago. Updated 6 months ago.

Status:
MODIFIED
Priority:
Normal
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Platform Release:
Blocks Release:
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Complexity:
Verified:
No
Verification Required:
No
Sprint:
Sprint 9

Description

pulp_celerybeat (2.Y) currently loads scheduled calls from mongodb. The 3.0 MVP will not load any scheduled tasks from the database. The code that handles the loading of schedule from DB should be removed.


Checklist


Related issues

Related to Pulp - Issue #1641: unit.server.db.model.test_dispatch.TestScheduledCallSave.test_new is non-deterministic CLOSED - WONTFIX Actions
Related to Pulp - Task #1978: Change the name of the scheduler worker from "scheduler" to "pulp_celerybeat" MODIFIED Actions
Related to Pulp - Task #2176: Remove auto-disable feature of scheduled tasks MODIFIED Actions
Blocked by Pulp - Refactor #2087: create django models for task system MODIFIED Actions

Associated revisions

Revision 365f9fd0 View on GitHub
Added by dkliban@redhat.com almost 3 years ago

Removes database backed celerybeat schedule

This change also converts worker watcher to use Django. This patch renames the scheduler to pulp_celerybeat.

closes: #2158
https://pulp.plan.io/issues/2158
closes: #2156
https://pulp.plan.io/issues/2156
closes: #1978
https://pulp.plan.io/issues/1978

blah

Revision 365f9fd0 View on GitHub
Added by dkliban@redhat.com almost 3 years ago

Removes database backed celerybeat schedule

This change also converts worker watcher to use Django. This patch renames the scheduler to pulp_celerybeat.

closes: #2158
https://pulp.plan.io/issues/2158
closes: #2156
https://pulp.plan.io/issues/2156
closes: #1978
https://pulp.plan.io/issues/1978

blah

Revision 365f9fd0 View on GitHub
Added by dkliban@redhat.com almost 3 years ago

Removes database backed celerybeat schedule

This change also converts worker watcher to use Django. This patch renames the scheduler to pulp_celerybeat.

closes: #2158
https://pulp.plan.io/issues/2158
closes: #2156
https://pulp.plan.io/issues/2156
closes: #1978
https://pulp.plan.io/issues/1978

blah

History

#1 Updated by mhrivnak about 3 years ago

  • Blocked by Refactor #2087: create django models for task system added

#2 Updated by mhrivnak about 3 years ago

  • Related to Issue #1641: unit.server.db.model.test_dispatch.TestScheduledCallSave.test_new is non-deterministic added

#3 Updated by bmbouter about 3 years ago

  • Checklist item Update the scheduler to use the Django models added
  • Checklist item hand test that a schedule in the database does dispatch tasks as expected added
  • Checklist item very that the failure count threshold has been removed added
  • Description updated (diff)
  • Groomed changed from No to Yes

#4 Updated by bmbouter about 3 years ago

  • Description updated (diff)

#5 Updated by mhrivnak about 3 years ago

  • Sprint/Milestone set to 25

#6 Updated by mhrivnak about 3 years ago

  • Sprint/Milestone changed from 25 to 26

#7 Updated by bmbouter about 3 years ago

This PR would be merged after the work I am doing on my branch. I've left the scheduler.py and worker_watcher.py untouched0. Those should be moved to pulp.tasking here1.

Also this story does not mention that the pulp_celerybeat needs to record the workers correctly in addition to handling scheduled calls. If that is supposed to be a separate story please file one.

[0]: https://github.com/bmbouter/pulp/tree/2154-Belgian-Dubbel/server/pulp/server/async
[1]: https://github.com/bmbouter/pulp/tree/2154-Belgian-Dubbel/tasking/pulp/tasking

#8 Updated by bmbouter about 3 years ago

  • Related to Task #1978: Change the name of the scheduler worker from "scheduler" to "pulp_celerybeat" added

#9 Updated by dkliban@redhat.com about 3 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to dkliban@redhat.com

#10 Updated by mhrivnak about 3 years ago

  • Related to Task #2176: Remove auto-disable feature of scheduled tasks added

#11 Updated by mhrivnak about 3 years ago

  • Sprint/Milestone changed from 26 to 27

#12 Updated by mhrivnak almost 3 years ago

Per PulpCon planning discussion, the MVP does not include the ability for a user to schedule tasks. We should revise this "refactor" issue accordingly.

#13 Updated by dkliban@redhat.com almost 3 years ago

  • Subject changed from Convert pulp_celerybeat to use scheduled calls from django to Remove pulp_celerybeat use of scheduled calls from database
  • Description updated (diff)

Updated the description and title to reflect the fact that 3.0 MVP will not execute any tasks using schedule data in the database.

#14 Updated by dkliban@redhat.com almost 3 years ago

  • Status changed from ASSIGNED to POST

#15 Updated by dkliban@redhat.com almost 3 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#16 Updated by bmbouter over 1 year ago

  • Sprint set to Sprint 9

#17 Updated by bmbouter over 1 year ago

  • Sprint/Milestone deleted (27)

#18 Updated by daviddavis 6 months ago

  • Sprint/Milestone set to 3.0

#19 Updated by bmbouter 6 months ago

  • Tags deleted (Pulp 3)

Please register to edit this issue

Also available in: Atom PDF