Issue #1637
closedPulp Admin returns 0 even when there are errors
Description
It is possible to create and sync a docker repository with the following commands:
pulp-admin docker repo create \
--feed ${feed} \
--repo-id ${repo_id} \
--upstream-name ${upstream_name}
pulp-admin docker repo sync --repo-id ${repo_id}
The second command returns a status code of 0 regardless of whether the sync succeeds.
Related issues
Updated by Ichimonji10 about 8 years ago
For an automated test which targets this issue, see https://github.com/PulpQE/pulp-smash/pull/94
Updated by rbarlow about 8 years ago
This is a general problem with pulp-admin - most error scenarios return 0 unfortunately.
Updated by Ichimonji10 about 8 years ago
Mmhmm. I remember hearing some chatter among the devs mentioning that fact.
I'll likely continue filing bugs like this. Doing so lets me provide a concrete reason for skipping certain tests.
Updated by ipanova@redhat.com about 8 years ago
Ichimonji10 wrote:
Mmhmm. I remember hearing some chatter among the devs mentioning that fact.
I'll likely continue filing bugs like this. Doing so lets me provide a concrete reason for skipping certain tests.
Would be helpful if you will make those issues as 'related'
Updated by kfiresmith about 8 years ago
ipanova@redhat.com wrote:
Ichimonji10 wrote:
Mmhmm. I remember hearing some chatter among the devs mentioning that fact.
I'll likely continue filing bugs like this. Doing so lets me provide a concrete reason for skipping certain tests.
Would be helpful if you will make those issues as 'related'
If anyone can point me toward the more general bug listing for this issue I'd love to weigh in - I need pulp-admin to be more predictable with exit codes so that I can count on it for use in a smaller single-Pulp-server infra that can't easily make use of Pulp event emailing.
Updated by Ichimonji10 about 8 years ago
Would be helpful if you will make those issues as 'related'
Sure. I'll make an effort to remember to do this. Thanks for the heads up.
Updated by bmbouter about 8 years ago
- Subject changed from Pulp Admin returns 0 even when docker sync fails to Pulp Admin returns 0 even when there are errors
- Severity changed from 2. Medium to 3. High
- Triaged changed from No to Yes
Updated by bmbouter about 8 years ago
- Is duplicate of Issue #427: Return code of the operation called by pulp-admin should be propagated to pulp-admin added