Pulp

The return code of pulp-admin is always 0 which is not correct. This is a broad issue so the example in this bug is one single example. This bug is to fix all return code usage.

Commands that were called by pulp-admin should propagate in a proper way their return codes to pulp-admin. In other words pulp-admin should have same return code as the command it called.

For the command:

pulp-admin -u admin -p admin rpm consumer package install run --name some_rpm --consumer-id c1

Produces the output:

Install task created with id [ 44307c9e-c721-4b56-8e87-1954c104e3de ]

This command may be exited via ctrl+c without affecting the request.

Refresh Repository Metadata

Install Failed

failure: repodata/repomd.xml from m2: [Errno 256] No more mirrors to
try.
https://example.com/pulp/repos/m2/repo
data/repomd.xml: [Errno 14] HTTPS Error 404 - Not Found

The return code in this case is still 0 which is incorrect.

[root@ec2-54-220-72-88 ~]# echo $?
0

If the script would call pulp-admin it would have to grep for any failure(that would complicate significantly the real life scenarios) instead of just checking the return code.