Actions
Issue #1348
closed
yum importer adds trailing slash, even when URL has a query string
Start date:
Due date:
Estimated time:
Severity:
1. Low
Version:
2.6.4
Platform Release:
2.8.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix, Pulp 2
Sprint:
Quarter:
Description
Two facts:
- SLES 12 repositories authorize CDN distribution via a GET param.
- The pulp_rpm yum importer unconditionally adds a trailing slash to all URLs that don't have one.
Here's the offender (from master commit at time of posting):
https://github.com/pulp/pulp_rpm/blob/9c62850f99724de2cef3da5f3898dce01434e4b8/plugins/pulp_rpm/plugins/importers/yum/sync.py#L94
Related issues
Updated by semyers over 8 years ago
- Status changed from NEW to ASSIGNED
- Tags Easy Fix added
Added by semyers over 8 years ago
Updated by semyers over 8 years ago
This was indeed an easy fix, but not a complete fix for SLES 12 in #928. Regardless, I've opened a PR:
Updated by ipanova@redhat.com over 8 years ago
- Status changed from ASSIGNED to POST
- Assignee set to semyers
- Platform Release set to 2.7.0
Updated by semyers over 8 years ago
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
Applied in changeset 63863b4952c425319fb82dbdac6fbca84deb0f88.
Updated by mhrivnak over 8 years ago
- Platform Release changed from 2.7.0 to 2.7.1
- Triaged changed from No to Yes
Updated by amacdona@redhat.com over 8 years ago
- Platform Release changed from 2.7.1 to 2.7.2
Updated by dkliban@redhat.com about 8 years ago
- Status changed from MODIFIED to 5
Updated by semyers almost 8 years ago
- Status changed from 5 to CLOSED - CURRENTRELEASE
- Platform Release changed from 2.7.2 to 2.8.0
Actions
.
Add trailing slash to URL path, not the entire URL
fixes #1348
This is built on some hefty changes made for 2.7, and (for the moment) isn't wanted by anyone but me (re #928), but can find its way as far back as pulp_rpm 2.4 if needed.