Project

Profile

Help

Issue #1348

closed

yum importer adds trailing slash, even when URL has a query string

Added by semyers about 7 years ago. Updated over 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
1. Low
Version:
2.6.4
Platform Release:
2.8.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix, Pulp 2
Sprint:
Quarter:

Description

Two facts:

  1. SLES 12 repositories authorize CDN distribution via a GET param.
  2. The pulp_rpm yum importer unconditionally adds a trailing slash to all URLs that don't have one.

Here's the offender (from master commit at time of posting):
https://github.com/pulp/pulp_rpm/blob/9c62850f99724de2cef3da5f3898dce01434e4b8/plugins/pulp_rpm/plugins/importers/yum/sync.py#L94


Related issues

Related to RPM Support - Task #928: Test with SLESCLOSED - NOTABUGsemyers

Actions
Actions #1

Updated by semyers about 7 years ago

Actions #2

Updated by semyers about 7 years ago

  • Status changed from NEW to ASSIGNED
  • Tags Easy Fix added

Added by semyers about 7 years ago

Revision 63863b49

Add trailing slash to URL path, not the entire URL

fixes #1348

This is built on some hefty changes made for 2.7, and (for the moment) isn't wanted by anyone but me (re #928), but can find its way as far back as pulp_rpm 2.4 if needed.

Actions #3

Updated by semyers about 7 years ago

This was indeed an easy fix, but not a complete fix for SLES 12 in #928. Regardless, I've opened a PR:

https://github.com/pulp/pulp_rpm/pull/730

Actions #4

Updated by ipanova@redhat.com about 7 years ago

  • Status changed from ASSIGNED to POST
  • Assignee set to semyers
  • Platform Release set to 2.7.0
Actions #5

Updated by semyers about 7 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions #6

Updated by mhrivnak about 7 years ago

  • Platform Release changed from 2.7.0 to 2.7.1
  • Triaged changed from No to Yes
Actions #7

Updated by semyers about 7 years ago

Actions #8

Updated by semyers about 7 years ago

Actions #9

Updated by amacdona@redhat.com almost 7 years ago

  • Platform Release changed from 2.7.1 to 2.7.2
Actions #10

Updated by dkliban@redhat.com almost 7 years ago

  • Status changed from MODIFIED to 5
Actions #11

Updated by semyers over 6 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE
  • Platform Release changed from 2.7.2 to 2.8.0
Actions #12

Updated by bmbouter over 3 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF