Issue #1348: yum importer adds trailing slash, even when URL has a query string - RPM Support - Pulp

Actions

Send by e-mail Copy link

Issue #1348

closed

yum importer adds trailing slash, even when URL has a query string

Added by semyers about 9 years ago. Updated over 5 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

semyers

Sprint/Milestone:

Start date:

Due date:

Estimated time:

Severity:

1. Low

Version:

2.6.4

Platform Release:

2.8.0

OS:

Triaged:

Yes

Groomed:

Sprint Candidate:

Tags:

Easy Fix, Pulp 2

Sprint:

Quarter:

Description

Two facts:

SLES 12 repositories authorize CDN distribution via a GET param.
The pulp_rpm yum importer unconditionally adds a trailing slash to all URLs that don't have one.

Here's the offender (from master commit at time of posting):
https://github.com/pulp/pulp_rpm/blob/9c62850f99724de2cef3da5f3898dce01434e4b8/plugins/pulp_rpm/plugins/importers/yum/sync.py#L94

Related issues

Actions

Copy link

Updated by semyers about 9 years ago

Blocks Task #928: Test with SLES added

Actions

Copy link

Updated by semyers about 9 years ago

Status changed from NEW to ASSIGNED
Tags Easy Fix added

Added by semyers about 9 years ago

Revision 63863b49 | View on GitHub

Add trailing slash to URL path, not the entire URL

fixes #1348

This is built on some hefty changes made for 2.7, and (for the moment) isn't wanted by anyone but me (re #928), but can find its way as far back as pulp_rpm 2.4 if needed.

Actions

Copy link