Project

Profile

Help

Issue #1135

Pulp's unit tests are not compatible with Mock>=1.1.0

Added by rbarlow over 5 years ago. Updated almost 2 years ago.

Status:
CLOSED - WONTFIX
Priority:
High
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

A new version of Mock was recently released that breaks compatibility with the version that Pulp had been using before (1.0.1). A bug has been filed about this with Mock[0], but may not be fixed. We should update Pulp's usages of Mock so that we are compliant with their new API.

[0] https://github.com/testing-cabal/mock/issues/263


Related issues

Blocked by Pulp - Task #931: Investigate and develop a plan for Pulp to use Software CollectionsCLOSED - CURRENTRELEASE

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

Associated revisions

Revision 2bacbcd5 View on GitHub
Added by rbarlow over 5 years ago

Pin the version of Mock that we use.

Pulp uses Mock in a way that is now broken[0] with the new version that was recently released. This commit pins us to use Mock<1.1 to avoid the problem for now. In the end, we should update our tests to use the new Mock API as part of the work on issue #1135.

[0] https://github.com/testing-cabal/mock/issues/263

re #1135

Revision 2bacbcd5 View on GitHub
Added by rbarlow over 5 years ago

Pin the version of Mock that we use.

Pulp uses Mock in a way that is now broken[0] with the new version that was recently released. This commit pins us to use Mock<1.1 to avoid the problem for now. In the end, we should update our tests to use the new Mock API as part of the work on issue #1135.

[0] https://github.com/testing-cabal/mock/issues/263

re #1135

Revision 88e8734c View on GitHub
Added by rbarlow over 5 years ago

Pin the version of Mock that we use.

Pulp uses Mock in a way that is now broken[0] with the new version that was recently released. This commit pins us to use Mock<1.1 to avoid the problem for now. In the end, we should update our tests to use the new Mock API as part of the work on issue #1135.

[0] https://github.com/testing-cabal/mock/issues/263

re #1135

Revision 88e8734c View on GitHub
Added by rbarlow over 5 years ago

Pin the version of Mock that we use.

Pulp uses Mock in a way that is now broken[0] with the new version that was recently released. This commit pins us to use Mock<1.1 to avoid the problem for now. In the end, we should update our tests to use the new Mock API as part of the work on issue #1135.

[0] https://github.com/testing-cabal/mock/issues/263

re #1135

History

#1 Updated by jortel@redhat.com over 5 years ago

  • Priority changed from Normal to High
  • Triaged changed from No to Yes

High priority to be sure we keep checking on the status of this upstream. When fixed, we need to remove our restriction on 1.0.1 in test_requirements and puppet module etc. And, verify Jenkins builds.

#2 Updated by amacdona@redhat.com over 5 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to amacdona@redhat.com

#3 Updated by amacdona@redhat.com over 5 years ago

  • Blocked by Task #931: Investigate and develop a plan for Pulp to use Software Collections added

#4 Updated by amacdona@redhat.com over 5 years ago

  • Status changed from ASSIGNED to NEW

Mock 1.1.0 officially drops python 2.6 support
http://mock.readthedocs.org/en/latest/changelog.html?highlight=spec_set#id7

I have set the plan to use software collections as a blocker, but more accurately, the real blocker should be actually switching to software collections, but there is not a task for that yet.

#5 Updated by amacdona@redhat.com over 5 years ago

  • Assignee deleted (amacdona@redhat.com)

#7 Updated by bmbouter almost 2 years ago

  • Status changed from NEW to CLOSED - WONTFIX

#8 Updated by bmbouter almost 2 years ago

Pulp 2 is approaching maintenance mode, and this Pulp 2 ticket is not being actively worked on. As such, it is being closed as WONTFIX. Pulp 2 is still accepting contributions though, so if you want to contribute a fix for this ticket, please reopen or comment on it. If you don't have permissions to reopen this ticket, or you want to discuss an issue, please reach out via the developer mailing list.

#9 Updated by bmbouter almost 2 years ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF