Issue #9427: Sync for BaseOS for AlmaLinux or CentOS 8 Stream fails with 'DistributionTree' object has no attribute 'filename' - Pulp

Actions

Send by e-mail Copy link

Issue #9427

closed

Sync for BaseOS for AlmaLinux or CentOS 8 Stream fails with 'DistributionTree' object has no attribute 'filename'

Added by ipanova@redhat.com about 3 years ago. Updated about 3 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

ggainey

Category:

Sprint/Milestone:

3.16.0

Start date:

Due date:

Estimated time:

Severity:

3. High

Version:

Platform Release:

OS:

Triaged:

Yes

Groomed:

Sprint Candidate:

Tags:

Sprint:

Sprint 105

Quarter:

Description

Offending line is this one https://github.com/pulp/pulpcore/blob/master/pulpcore/plugin/stages/artifact_stages.py#L355 and was introduced with this commit https://github.com/pulp/pulpcore/commit/349f2137d970f87190749b417cfa137dc0f99ff5#diff-28560cb4dba596314e3577becbd1974a015d47c08f8f17b38e6030a701999169 which landed in 3.15.0 and backported to 3.14.z We cannot reference filename on the content https://github.com/pulp/pulpcore/blob/master/pulpcore/app/models/content.py#L467

Related issues

Actions

Copy link

Updated by ipanova@redhat.com about 3 years ago

Subject changed from Sync for BaseOS for AlmaLinux or CentOS 8 Stream 'DistributionTree' object has no attribute 'filename' to Sync for BaseOS for AlmaLinux or CentOS 8 Stream fails with 'DistributionTree' object has no attribute 'filename'

Actions

Copy link

Updated by ipanova@redhat.com about 3 years ago

Project changed from RPM Support to Pulp

Actions

Copy link

Updated by ipanova@redhat.com about 3 years ago

more context https://community.theforeman.org/t/issues-with-syncing-aarch64-baseos-repos/25341/2

Actions

Copy link

Updated by dalley about 3 years ago

We should have a test for this also.

Actions

Copy link

Updated by dalley about 3 years ago

Severity changed from 2. Medium to 3. High
Triaged changed from No to Yes
Sprint set to Sprint 105

Actions

Copy link

Updated by ggainey about 3 years ago

Status changed from NEW to ASSIGNED

Actions

Copy link

Updated by ggainey about 3 years ago

This is def a bug, and I am prepping a PR for it. However, I cannot reproduce the problem on core/master. Using the following remotes:

    http://mirror.phx1.us.spryservers.net/almalinux/8.4/BaseOS/aarch64/kickstart/    
    https://mirror.slu.cz/rocky/8.4/BaseOS/aarch64/kickstart/ 
    http://mirror.phx1.us.spryservers.net/almalinux/8.4/BaseOS/aarch64/os/                    
    https://mirror.slu.cz/rocky/8.4/BaseOS/aarch64/os/ 
    http://mirror.centos.org/centos/8-stream/BaseOS/aarch64/os/

I have sync'd on_demand, immediate (for ks-repos), autopublish, and mirror. Duplicate-file-paths I get - but not the failure noted in the foreman-issue in #c3. core/master is 3.16dev, and there have been a number of fixes addressing remote-artifacts since 3.14. It's possible we just never hit this path any more. It's also possible that the repos were in a suboptimal state which has been fixed - CentOS8-Stream, for example, was updated yesterday.

In any event - the traceback is a bug, PR to address it incoming.

Actions

Copy link

Updated by ggainey about 3 years ago

Status changed from ASSIGNED to POST

https://github.com/pulp/pulpcore/pull/1639

Actions

Copy link

Updated by dalley about 3 years ago

Assignee set to ggainey

Actions

Copy link

#10

Updated by pulpbot about 3 years ago

PR: https://github.com/pulp/pulpcore/pull/1639

Actions

Copy link

#11

Updated by dalley about 3 years ago

Sprint/Milestone set to 3.16.0

Actions

Copy link

#12

Updated by dalley about 3 years ago

Copied to Backport #9440: Backport #9427 "Sync for BaseOS for AlmaLinux or CentOS 8 Stream fails with 'DistributionTree' object has no attribute 'filename'" added