Project

Profile

Help

Issue #9387

closed

Depsolving computes repoclosure once per-rpm being copied

Added by ggainey about 3 years ago. Updated about 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Urgent
Assignee:
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
3. High
Version:
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 105
Quarter:

Description

Unlike Pulp2, Pulp3 on-copy depsolving is computing repoclosure on the destination repo once per RPM copied . It only takes 1s to compute - but when copying 10K rpms, that adds up, in both CPU and memory.


Related issues

Has duplicate RPM Support - Issue #9335: Huge memory consumption when performing depsolving-enabled copiesCLOSED - DUPLICATEggaineyActions
Copied to RPM Support - Backport #9388: Backport "Depsolving computes repoclosure once per-rpm being copied" to 3.14.zCLOSED - CURRENTRELEASE

Actions
Actions #1

Updated by ggainey about 3 years ago

The reason this is happening is that we addressed https://pulp.plan.io/issues/6820. My contention is tha the bahvior called out by 6820 is in fact correct. On copy, what we try to insure is repoclosure for yum/dnf's sake - if you issue "dnf install foo" should result in the latest version of foo being installed.

Note that Pulp2 depsolving code currently also only does repo-closure on the final repo - see https://github.com/pulp/pulp_rpm/blob/2-master/plugins/pulp_rpm/plugins/importers/yum/pulp_solv.py#L987-L990

Actions #2

Updated by ggainey about 3 years ago

  • Copied to Backport #9388: Backport "Depsolving computes repoclosure once per-rpm being copied" to 3.14.z added
Actions #3

Updated by pulpbot about 3 years ago

  • Status changed from ASSIGNED to POST

Added by ggainey about 3 years ago

Revision 4594deb8 | View on GitHub

Fix depsolving perf-issues by doing repoclosure once.

fixes #9387. [nocoverage]

Actions #4

Updated by ggainey about 3 years ago

  • Status changed from POST to MODIFIED
Actions #5

Updated by dalley about 3 years ago

  • Sprint/Milestone set to 3.16.0
Actions #6

Updated by dalley about 3 years ago

  • Has duplicate Issue #9335: Huge memory consumption when performing depsolving-enabled copies added
Actions #7

Updated by pulpbot about 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF