Issue #9029: Problems when syncing identical repositories simultaneously - RPM Support - Pulp

Actions

Send by e-mail Copy link

Issue #9029

closed

Problems when syncing identical repositories simultaneously

Added by dalley over 3 years ago. Updated over 3 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

High

Assignee:

dalley

Sprint/Milestone:

3.15.0

Start date:

Due date:

Estimated time:

Severity:

3. High

Version:

Platform Release:

OS:

Triaged:

Yes

Groomed:

Sprint Candidate:

Tags:

Katello

Sprint:

Sprint 103

Quarter:

Description

Unguarded uses of bulk_create() are not resilient to races when repositories are synced simultaneously, causing one or both of the syncs to fail.

            if addons:
                Addon.objects.bulk_create(addons)
            if checksums:
                Checksum.objects.bulk_create(checksums)
            if images:
                Image.objects.bulk_create(images)
            if variants:
                Variant.objects.bulk_create(variants)

Related issues

Actions

Copy link

Updated by dalley over 3 years ago

Description updated (diff)

Actions

Copy link

Updated by dalley over 3 years ago

Severity changed from 2. Medium to 3. High
Triaged changed from No to Yes
Sprint set to Sprint 101

Actions

Copy link

Updated by ggainey over 3 years ago

pulpcore uses of bulk_create():

(master) ~/github/Pulp3/pulpcore/pulpcore/app $ find . -name \*.py | xargs grep "bulk_create("
./models/repository.py:        RepositoryContent.objects.bulk_create(repo_content)
./models/repository.py:            RepositoryVersionContentDetails.objects.bulk_create(counts_list)
./models/content.py:                return super().bulk_create(objs, batch_size=batch_size)

Actions

Copy link