Project

Profile

Help

Issue #8868

Bindings don't properly namespace API

Added by daviddavis 4 months ago. Updated 3 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Category:
-
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
API Bindings
Sprint:
Sprint 99
Quarter:

Description

The pulp exports API lives at endpoint /api/v3/pulp/exporters/core/pulp/<uuid>/exports/. For whatever reason, the bindings that get generated name this ExportersCoreExportsApi (see here)

I am adding a new export type (FilesystemExport at /api/v3/pulp/exporters/core/filesystem/<uuid>/exports/) and the bindings are adding two sets of methods to ExportersCoreExportsApi (e.g. create and create_0).

I believe there should be some sort of namespace in there like ExportersPulpExportsApi or ExportersCorePulpExportsApi.


Related issues

Blocks Pulp - Task #8860: Move FilesystemExporter out of plugin API into pulpcoreCLOSED - CURRENTRELEASE

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

Associated revisions

Revision 21494e17 View on GitHub
Added by dkliban@redhat.com 3 months ago

Fix OpenAPI schema tag generation

The tag generation code was deleting the second element from the end instead of deleting the second element in the list of operation keys. This worked for operations that had 3 elements in the operations keys list, however, anything longer produced wrong operation tags.

fixes: #8868 https://pulp.plan.io/issues/8868

History

#1 Updated by daviddavis 3 months ago

  • Blocks Task #8860: Move FilesystemExporter out of plugin API into pulpcore added

#2 Updated by dkliban@redhat.com 3 months ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 98

#3 Updated by rchan 3 months ago

  • Sprint changed from Sprint 98 to Sprint 99

#4 Updated by dkliban@redhat.com 3 months ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to dkliban@redhat.com

#5 Updated by pulpbot 3 months ago

  • Status changed from ASSIGNED to POST

#6 Updated by dkliban@redhat.com 3 months ago

  • Status changed from POST to MODIFIED

#7 Updated by pulpbot 3 months ago

  • Sprint/Milestone set to 3.14.0

#8 Updated by pulpbot 3 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF