Project

Profile

Help

Issue #8868

closed

Bindings don't properly namespace API

Added by daviddavis about 3 years ago. Updated almost 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Category:
-
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
API Bindings
Sprint:
Sprint 99
Quarter:

Description

The pulp exports API lives at endpoint /api/v3/pulp/exporters/core/pulp/<uuid>/exports/. For whatever reason, the bindings that get generated name this ExportersCoreExportsApi (see here)

I am adding a new export type (FilesystemExport at /api/v3/pulp/exporters/core/filesystem/<uuid>/exports/) and the bindings are adding two sets of methods to ExportersCoreExportsApi (e.g. create and create_0).

I believe there should be some sort of namespace in there like ExportersPulpExportsApi or ExportersCorePulpExportsApi.


Related issues

Blocks Pulp - Task #8860: Move FilesystemExporter out of plugin API into pulpcoreCLOSED - CURRENTRELEASEdaviddavis

Actions
Actions #1

Updated by daviddavis about 3 years ago

  • Blocks Task #8860: Move FilesystemExporter out of plugin API into pulpcore added
Actions #2

Updated by dkliban@redhat.com about 3 years ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 98
Actions #3

Updated by rchan almost 3 years ago

  • Sprint changed from Sprint 98 to Sprint 99
Actions #4

Updated by dkliban@redhat.com almost 3 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to dkliban@redhat.com
Actions #5

Updated by pulpbot almost 3 years ago

  • Status changed from ASSIGNED to POST

Added by dkliban@redhat.com almost 3 years ago

Revision 21494e17 | View on GitHub

Fix OpenAPI schema tag generation

The tag generation code was deleting the second element from the end instead of deleting the second element in the list of operation keys. This worked for operations that had 3 elements in the operations keys list, however, anything longer produced wrong operation tags.

fixes: #8868 https://pulp.plan.io/issues/8868

Actions #6

Updated by dkliban@redhat.com almost 3 years ago

  • Status changed from POST to MODIFIED
Actions #7

Updated by pulpbot almost 3 years ago

  • Sprint/Milestone set to 3.14.0
Actions #8

Updated by pulpbot almost 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF