Project

Profile

Help

Backport #8818

Backport to 2.2: Schema converter returns digest value without digest algoritm

Added by ipanova@redhat.com 5 months ago. Updated 5 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Triaged:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 97
Quarter:

Description

https://pulp.plan.io/issues/8629

As a result docker-content-digest response header contains only the hash of sha256 instead of sha256: <hash> string.

This leads to pulp3 to pulp2 failure and docker pull fails with older clients.

The issue was introduce with this commit https://github.com/pulp/pulp_container/commit/0a362e236bcf2d5ecac15afd4d8d5d166f732637#diff-c035f88089448e23039b5c302d6d17d169a92cfbdc325c75a0ddf3fd7e3a46b4R286

$ http http://pulp2-nightly-pulp3-source-centos7.lan/pulp/container/ocp3/manifests/v3.7.42-2
HTTP/1.1 200 OK
Connection: Keep-Alive
Content-Length: 5405
Content-Type: application/vnd.docker.distribution.manifest.v1+prettyjws; charset=utf-8
Date: Mon, 26 Apr 2021 21:56:20 GMT
Docker-Content-Digest: fc8071636efc3f654d50b4e7f1dea9fdc1face1a30c7f5d42665c964666dbca
Docker-Distribution-API-Version: registry/2.0
Keep-Alive: timeout=5, max=10000
Server: Python/3.6 aiohttp/3.7.4

Related issues

Copied from Container Support - Backport #8698: Backport to 2.5: Schema converter returns digest value without digest algoritmCLOSED - CURRENTRELEASE

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

Associated revisions

Revision ab554ae2 View on GitHub
Added by ipanova@redhat.com 5 months ago

Fixed schema conversion so the digest string contains algorithm.

closes #8818 backports #8629

(cherry picked from commit 8808e63eebda91aac263d905b67be5c99f74c8e8)

Revision ab554ae2 View on GitHub
Added by ipanova@redhat.com 5 months ago

Fixed schema conversion so the digest string contains algorithm.

closes #8818 backports #8629

(cherry picked from commit 8808e63eebda91aac263d905b67be5c99f74c8e8)

History

#1 Updated by ipanova@redhat.com 5 months ago

  • Copied from Backport #8698: Backport to 2.5: Schema converter returns digest value without digest algoritm added

#2 Updated by ipanova@redhat.com 5 months ago

  • Assignee deleted (mdellweg)
  • Sprint deleted (Sprint 96)

#3 Updated by ipanova@redhat.com 5 months ago

  • Description updated (diff)

#4 Updated by ipanova@redhat.com 5 months ago

  • Sprint/Milestone set to 2.2.2

#5 Updated by ipanova@redhat.com 5 months ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ipanova@redhat.com
  • Sprint set to Sprint 97

#6 Updated by pulpbot 5 months ago

  • Status changed from ASSIGNED to POST

#7 Updated by ipanova@redhat.com 5 months ago

  • Status changed from POST to MODIFIED

#8 Updated by pulpbot 5 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF