Project

Profile

Help

Actions
Send by e-mail Copy link

Backport #8698

closed

Backport to 2.5: Schema converter returns digest value without digest algoritm

Added by ipanova@redhat.com almost 3 years ago. Updated almost 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
mdellweg
Sprint/Milestone:
2.5.3
Start date:
Due date:
% Done:

100%

Estimated time:
Triaged:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 96
Quarter:

Description

As a result docker-content-digest response header contains only the hash of sha256 instead of sha256: <hash> string.

This leads to pulp3 to pulp2 failure and docker pull fails with older clients.

The issue was introduce with this commit https://github.com/pulp/pulp_container/commit/0a362e236bcf2d5ecac15afd4d8d5d166f732637#diff-c035f88089448e23039b5c302d6d17d169a92cfbdc325c75a0ddf3fd7e3a46b4R286

$ http http://pulp2-nightly-pulp3-source-centos7.lan/pulp/container/ocp3/manifests/v3.7.42-2
HTTP/1.1 200 OK
Connection: Keep-Alive
Content-Length: 5405
Content-Type: application/vnd.docker.distribution.manifest.v1+prettyjws; charset=utf-8
Date: Mon, 26 Apr 2021 21:56:20 GMT
Docker-Content-Digest: fc8071636efc3f654d50b4e7f1dea9fdc1face1a30c7f5d42665c964666dbca
Docker-Distribution-API-Version: registry/2.0
Keep-Alive: timeout=5, max=10000
Server: Python/3.6 aiohttp/3.7.4

Related issues

Copied from Container Support - Issue #8629: Schema converter returns digest value without digest algoritmCLOSED - CURRENTRELEASEipanova@redhat.comActions
Copied to Container Support - Backport #8818: Backport to 2.2: Schema converter returns digest value without digest algoritmCLOSED - CURRENTRELEASEipanova@redhat.com

Actions
Actions
Copy link
 #1

Updated by ipanova@redhat.com almost 3 years ago

  • Copied from Issue #8629: Schema converter returns digest value without digest algoritm added
Actions
Copy link
 #2

Updated by mdellweg almost 3 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to mdellweg
Actions
Copy link
 #3

Updated by pulpbot almost 3 years ago

  • Status changed from ASSIGNED to POST

Added by mdellweg almost 3 years ago

Revision 96e1089d | View on GitHub

Fixed schema conversion so the digest string contains algorithm.

backports #8629

fixes #8698

(cherry picked from commit 8808e63eebda91aac263d905b67be5c99f74c8e8)

Added by mdellweg almost 3 years ago

Revision 96e1089d | View on GitHub

Fixed schema conversion so the digest string contains algorithm.

backports #8629

fixes #8698

(cherry picked from commit 8808e63eebda91aac263d905b67be5c99f74c8e8)

Actions
Copy link
 #4

Updated by mdellweg almost 3 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions
Copy link
 #5

Updated by ipanova@redhat.com almost 3 years ago

  • Sprint changed from Sprint 95 to Sprint 96
Actions
Copy link
 #6

Updated by pulpbot almost 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Copy link
 #7

Updated by Mactech001 almost 3 years ago

  • File pc-matic-home_8ubk.jpg added
Actions
Copy link
 #8

Updated by mdellweg almost 3 years ago

  • File deleted (pc-matic-home_8ubk.jpg)
Actions
Copy link
 #9

Updated by ipanova@redhat.com almost 3 years ago

  • Copied to Backport #8818: Backport to 2.2: Schema converter returns digest value without digest algoritm added
Actions
Send by e-mail Copy link

Also available in: Atom PDF