Task #8740
closed[EPIC] Publication based plugins should use either `distribution.repository` or `distribution.publication` but not both
100%
Description
Ticket moved to GitHub: "pulp/pulpcore/1993":https://github.com/pulp/pulpcore/issues/1993
Problems¶
-
Currently, when auto-publish creates a publication, for distributions to go live with that the code needs to make a data change on the distribution. Here is an example in pulp_rpm. This requires the sync+publish code to lock on every distribution referencing the repository being sync'd. So instead of a lock like
["repository foo"]
you get["repository foo", "some distribution" "another distribution", "maybe a third distribution"]
. -
Using both fields doesn't capture the user's intent. If a user wants to have a distribution always publish the latest publication setting the
distribution.repository
captures that nicely. If a user wants to have a distribution distribute a specific version of a publication (even if newer ones get created) settingdistribution.publication
captures that nicely. What we've got though is both fields being used together which captures conflicting requirements, they want the latest publication for a repository, but they also want this specific publication? If thedistribution.publication
is poiting to the latest publication then we're using two pieces of data when we only need one.
Why did we do it this way?¶
I suspect because it was convenient since the content app already knows how to serve distribution.publication so by setting that data the publication will serve correctly.
What to do instead?¶
- For plugins that use publications, have their
Distribution
serializers validate to not allow bothrepository
andpublication
at the same time. - Provide a migration to fix the data in cases where both are used.
- Update the content app to find the latest publication when
MyDistribution.repository
is set andMyDistribution.publication
is unset. This would happen here. This is roughly how the content app auto distributes non-publication plugins, see the implementation here.
Related issues
Updated by bmbouter over 3 years ago
By not having to also update the distributions I think we'll be going a step closer to this request also: https://pulp.plan.io/issues/8673
Updated by dalley over 3 years ago
I would additionally suggest adding a database constraint (in core) so that plugin writers can't violate this invariant or mess up the validation.
Something equivalent to
~Q(repository_isnull=False, repository_version__isnull=False) & ~Q(repository_isnull=False, publication__isnull=False)
Updated by dalley over 3 years ago
- Related to Story #8673: Auto-publishing should be more fault-tolerant added
Updated by bmbouter over 3 years ago
dalley, would you be able to list the plugins that need this change?
Updated by dalley over 3 years ago
It should be only file, rpm, and python.
But only file has been released with support AFAIK.
Updated by bmbouter over 3 years ago
- Subject changed from Publication based plugins should use either `distribution.repository` or `distribution.publication` but not both to [EPIC] Publication based plugins should use either `distribution.repository` or `distribution.publication` but not both
Updated by pulpbot almost 3 years ago
- Description updated (diff)
- Status changed from NEW to CLOSED - DUPLICATE