Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #7845

closed

The view_set parameter on AccessPolicy is not namespacing plugins

Added by mdellweg about 4 years ago. Updated almost 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Urgent
Assignee:
mdellweg
Category:
-
Sprint/Milestone:
3.9.0
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 86
Quarter:

Description

We need to use another deterninant here because e.g. PackageViewSet will appear in multiple plugins.

In: ContainerDistributionViewSet.view_name()
Out: 'distributions-container/container'

would do the job.

If no plugin is using AccessPolicy by now, we can just switch the lookup here. Otherwise we'd need to be very careful with deprecating it, because a failed lookup will result in "500" errors.

Actions
Copy link
 #1

Updated by mdellweg almost 4 years ago

  • Sprint/Milestone set to 3.9.0
Actions
Copy link
 #2

Updated by fao89 almost 4 years ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 86
Actions
Copy link
 #3

Updated by pulpbot almost 4 years ago

  • Status changed from ASSIGNED to POST

Added by mdellweg almost 4 years ago

Revision 7f738e07 | View on GitHub

Namespace vieset_name in AccessPolicy

To avoid naming conflicts with similarly named viewsets in plugins, a scoping by the plugin app_id is needed.

fixes #7845 https://pulp.plan.io/issues/7845

Actions
Copy link
 #4

Updated by mdellweg almost 4 years ago

  • Status changed from POST to MODIFIED
Actions
Copy link
 #5

Updated by pulpbot almost 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Send by e-mail Copy link

Also available in: Atom PDF