Project

Profile

Help

Issue #7845

The view_set parameter on AccessPolicy is not namespacing plugins

Added by mdellweg 2 months ago. Updated about 2 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Urgent
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 86
Quarter:

Description

We need to use another deterninant here because e.g. PackageViewSet will appear in multiple plugins.

In: ContainerDistributionViewSet.view_name()
Out: 'distributions-container/container'

would do the job.

If no plugin is using AccessPolicy by now, we can just switch the lookup here. Otherwise we'd need to be very careful with deprecating it, because a failed lookup will result in "500" errors.

Associated revisions

Revision 7f738e07 View on GitHub
Added by mdellweg about 2 months ago

Namespace vieset_name in AccessPolicy

To avoid naming conflicts with similarly named viewsets in plugins, a scoping by the plugin app_id is needed.

fixes #7845 https://pulp.plan.io/issues/7845

History

#1 Updated by mdellweg 2 months ago

  • Sprint/Milestone set to 3.9.0

#2 Updated by fao89 2 months ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 86

#3 Updated by pulpbot 2 months ago

  • Status changed from ASSIGNED to POST

#4 Updated by mdellweg about 2 months ago

  • Status changed from POST to MODIFIED

#5 Updated by pulpbot about 2 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF