Project

Profile

Help

Actions
Send by e-mail Copy link

Story #7464

closed

As a plugin writer, I can subclass and re-use ArtifactDownloader

Added by bmbouter about 4 years ago. Updated almost 3 years ago.

Status:
CLOSED - DUPLICATE
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

Ticket moved to GitHub: "pulp/pulpcore/1931":https://github.com/pulp/pulpcore/issues/1931

Background

Other plugin code wants to have "downloading" stages too! For example pulp_ansible needs to download DocsBlogs and has a custom stage for it.

The Issue

  1. The ArtifactDownloader doesn't have customized progress reporting here.

  2. The ArtifactDownloader is not a great name when you're not techinically downlading artifacts.

Proposal

  1. Rename ArtifactDownloader to GenericDownloader
  2. Have the progress reporting "message" be a class attribute named PROGRESS_REPORTING_MESSAGE on GenericDownloader
  3. Have the ArtifactDownloader subclass GenericDownloader and set the PROGRESS_REPORTING_MESSAGE.

Related issues

Related to Pulp - Refactor #7352: Provide a better abstraction for customizing downloader behaviorCLOSED - DUPLICATE

Actions
Actions
Send by e-mail Copy link

Also available in: Atom PDF