Project

Profile

Help

Refactor #7352

Provide a better abstraction for customizing downloader behavior

Added by dalley 8 months ago. Updated 3 months ago.

Status:
NEW
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Wishlist
Sprint:
Quarter:

Description

Customization of downloader behavior is currently achieved by subclassing one of the downloader types from the Plugin API and then modifying the get_downloader() method and downloader_factory property on the Remote (sub)class.

A limitation of this abstraction is that while the get_downloader() method accepts **kwargs to pass down to the (possibly customized) downloader, it will pass all kwargs to any downloader without discriminating by the type of downloader. Therefore it's difficult to send a kwarg to be used on a customized HTTP downloader without it being also sent to other types of downloaders such as FileDownloader which are not expecting it.

This could be worked around by additionally modifying the DownloaderFactory, but it's currently suboptimal because:

  • The methods you'd want to override are underscore-prefixed (private)
  • It would create extra coupling and interdependence between the classes; not the end of the world, but kind of messy

We could probably benefit from revisiting the design and incorporate some of our experience with customizing downloader behavior in various plugins.


Related issues

Related to RPM Support - Issue #7342: file:// repo syncing fails with unexpected keyword argument 'silence_errors_for_response_status_codes'CLOSED - CURRENTRELEASE<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by dalley 8 months ago

  • Related to Issue #7342: file:// repo syncing fails with unexpected keyword argument 'silence_errors_for_response_status_codes' added

#2 Updated by dkliban@redhat.com 3 months ago

  • Status changed from NEW to CLOSED - WONTFIX

We will not get to this in the near future.

#3 Updated by dalley 3 months ago

  • Status changed from CLOSED - WONTFIX to NEW
  • Tags Pulp-NEXT added

#4 Updated by dalley 3 months ago

  • Tags Wishlist added
  • Tags deleted (Pulp-NEXT)

Please register to edit this issue

Also available in: Atom PDF