Actions
Story #7464
closed
As a plugin writer, I can subclass and re-use ArtifactDownloader
Status:
CLOSED - DUPLICATE
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:
0%
Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:
Description
Ticket moved to GitHub: "pulp/pulpcore/1931":https://github.com/pulp/pulpcore/issues/1931
Background¶
Other plugin code wants to have "downloading" stages too! For example pulp_ansible needs to download DocsBlogs and has a custom stage for it.
The Issue¶
-
The ArtifactDownloader doesn't have customized progress reporting here.
-
The
ArtifactDownloaderis not a great name when you're not techinically downlading artifacts.
Proposal¶
- Rename
ArtifactDownloadertoGenericDownloader - Have the progress reporting "message" be a class attribute named
PROGRESS_REPORTING_MESSAGEonGenericDownloader - Have the
ArtifactDownloadersubclassGenericDownloaderand set thePROGRESS_REPORTING_MESSAGE.
Related issues
Updated by dalley over 3 years ago
- Related to Refactor #7352: Provide a better abstraction for customizing downloader behavior added
Updated by pulpbot almost 3 years ago
- Description updated (diff)
- Status changed from NEW to CLOSED - DUPLICATE
Actions
.