Project

Profile

Help

Issue #7063

pulp_installer adds a redis PPA on all Ubuntu releases

Added by mdepaulo@redhat.com 2 days ago. Updated about 5 hours ago.

Status:
MODIFIED
Priority:
Normal
Category:
Installer
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
Yes
Tags:
Sprint:
Sprint 76

Description

pulp_installer has the following task: https://github.com/pulp/pulp_installer/blob/master/roles/pulp_redis/tasks/main.yml#L16

- name: Add redis repository
  apt_repository:
    repo: ppa:chris-lea/redis-server
  become: yes
  when: ansible_distribution == 'Ubuntu'

This contradicts our policy against adding 3rd-party repos (anything beyond EPEL or the distro's misc optional repos) to a system.

The ansible task was added as part of this redmine task: https://pulp.plan.io/issues/4312

Considering that our Travis env was using Ubuntu 14.04 at the time, this strongly implies that the ansible task was a workaround for Ubuntu 14.04. Ubuntu 14.04 had redis 2.x, whereas CentOS 7 / EPEL 7 has redis 3.x (which we use successfully), and Ubuntu 16.04 has redis 3.x.

We have 2 possible solutions:

  1. Remove the task entirely.
  2. Make it only perform its logic on Ubuntu 14.04.

Either way, we cannot safely remove the repo from existing systems with a "cleanup"/delete task of some kind. (Since presumably redis will stop functioning if it is downgraded, but has /var state on disk.)

Also, our CI does not target Ubuntu currently. Debian 10 buster is the only targetted distro in the Debian family.


Related issues

Related to Pulp - Task #4312: Switch Travis-CI to use Pulp 3 installerCLOSED - CURRENTRELEASE

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

Associated revisions

Revision 475a3f9f View on GitHub
Added by Mike DePaulo about 8 hours ago

Problem: pulp_installer adds a redis PPA

on all Ubuntu releases

Solution: Remove the task that adds the redis PPA. It was probably only ever needed on Ubuntu 14.04, which is EOL.

fixes: #7063 pulp_installer adds a redis PPA on all Ubuntu releases https://pulp.plan.io/issues/7063

History

#1 Updated by mdepaulo@redhat.com 2 days ago

  • Related to Task #4312: Switch Travis-CI to use Pulp 3 installer added

#2 Updated by dkliban@redhat.com 1 day ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 76

We should drop support for ubuntu 14.04 by dropping this one task.

#3 Updated by mdepaulo@redhat.com about 8 hours ago

  • Assignee set to mdepaulo@redhat.com

#4 Updated by pulpbot about 8 hours ago

  • Status changed from NEW to POST

#5 Updated by Anonymous about 5 hours ago

  • Status changed from POST to MODIFIED

Please register to edit this issue

Also available in: Atom PDF