Issue #7063
closedpulp_installer adds a redis PPA on all Ubuntu releases
Description
pulp_installer has the following task: https://github.com/pulp/pulp_installer/blob/master/roles/pulp_redis/tasks/main.yml#L16
- name: Add redis repository
apt_repository:
repo: ppa:chris-lea/redis-server
become: yes
when: ansible_distribution == 'Ubuntu'
This contradicts our policy against adding 3rd-party repos (anything beyond EPEL or the distro's misc optional repos) to a system.
The ansible task was added as part of this redmine task: https://pulp.plan.io/issues/4312
Considering that our Travis env was using Ubuntu 14.04 at the time, this strongly implies that the ansible task was a workaround for Ubuntu 14.04. Ubuntu 14.04 had redis 2.x, whereas CentOS 7 / EPEL 7 has redis 3.x (which we use successfully), and Ubuntu 16.04 has redis 3.x.
We have 2 possible solutions:
- Remove the task entirely.
- Make it only perform its logic on Ubuntu 14.04.
Either way, we cannot safely remove the repo from existing systems with a "cleanup"/delete task of some kind. (Since presumably redis will stop functioning if it is downgraded, but has /var state on disk.)
Also, our CI does not target Ubuntu currently. Debian 10 buster is the only targetted distro in the Debian family.
Related issues
Updated by mdepaulo@redhat.com over 4 years ago
- Related to Task #4312: Switch Travis-CI to use Pulp 3 installer added
Updated by dkliban@redhat.com over 4 years ago
- Triaged changed from No to Yes
- Sprint set to Sprint 76
We should drop support for ubuntu 14.04 by dropping this one task.
Updated by mdepaulo@redhat.com over 4 years ago
- Assignee set to mdepaulo@redhat.com
Added by Mike DePaulo over 4 years ago
Added by Mike DePaulo over 4 years ago
Revision 475a3f9f | View on GitHub
Problem: pulp_installer adds a redis PPA
on all Ubuntu releases
Solution: Remove the task that adds the redis PPA. It was probably only ever needed on Ubuntu 14.04, which is EOL.
fixes: #7063 pulp_installer adds a redis PPA on all Ubuntu releases https://pulp.plan.io/issues/7063
Updated by pulpbot over 4 years ago
- Status changed from NEW to POST
Updated by Anonymous over 4 years ago
- Status changed from POST to MODIFIED
Applied in changeset ansible-pulp|475a3f9f711f0b7b136057e826d06e305e8e37a5.
Updated by Anonymous over 4 years ago
Applied in changeset ansible-pulp3|475a3f9f711f0b7b136057e826d06e305e8e37a5.
Updated by hinduparv over 4 years ago
- File My brother is sweeter than Chanda, my brother is different from Others.Brother gave so much love, I spent this life on him.Mother gave life, but you decorated her.May my blessings on Rakhi day be filled with happin.jpg added
Updated by fao89 over 4 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Updated by lmjachky over 4 years ago
- File deleted (
My brother is sweeter than Chanda, my brother is different from Others.Brother gave so much love, I spent this life on him.Mother gave life, but you decorated her.May my blessings on Rakhi day be filled with happin.jpg)
Problem: pulp_installer adds a redis PPA
on all Ubuntu releases
Solution: Remove the task that adds the redis PPA. It was probably only ever needed on Ubuntu 14.04, which is EOL.
fixes: #7063 pulp_installer adds a redis PPA on all Ubuntu releases https://pulp.plan.io/issues/7063